dart2js: move recording of interceptorInvocationNames from addParameterStub.

dart2js: move recording of interceptorInvocationNames from addParameterStub.

This is done as a step towards sharing the generation of parameter stubs between the new and the old emitter. The remaining code in addParameterStub is now independent of the old emitter.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43326

[zarah, 2015-01-29 16:51:38]

zarah@google.com changed reviewers:
+ floitsch@google.com, herhut@google.com

[floitsch, 2015-01-29 17:27:10]

LGTM with comments.

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:262:
emitter.interceptorEmitter.
You seem to be missing the test that the member is indeed intercepted.

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:265:
builder.addProperty(namer.invocationName(selector),
reuse invocationName local.

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:343:
emitter.interceptorEmitter.
ditto: missing the check that it is an interceptor.

[zarah, 2015-01-29 18:24:18]

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:262:
emitter.interceptorEmitter.
On 2015/01/29 17:27:10, floitsch wrote:
> You seem to be missing the test that the member is indeed intercepted.

The check is done in recordMangledNameOfMemberMethod.

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:265:
builder.addProperty(namer.invocationName(selector),
On 2015/01/29 17:27:10, floitsch wrote:
> reuse invocationName local.

Done.

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:343:
emitter.interceptorEmitter.
On 2015/01/29 17:27:10, floitsch wrote:
> ditto: missing the check that it is an interceptor.

Same as above.

[floitsch, 2015-01-29 18:38:09]

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://codereview.chromium.org/890583003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:262:
emitter.interceptorEmitter.
On 2015/01/29 18:24:18, zarah wrote:
> On 2015/01/29 17:27:10, floitsch wrote:
> > You seem to be missing the test that the member is indeed intercepted.
> 
> The check is done in recordMangledNameOfMemberMethod.

Acknowledged.

[floitsch, 2015-01-29 20:52:48]

https://chromiumcodereview.appspot.com/890583003/diff/20001/pkg/compiler/lib/...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://chromiumcodereview.appspot.com/890583003/diff/20001/pkg/compiler/lib/...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:262:
emitter.interceptorEmitter.
nit: put the "." into the next line.

[zarah, 2015-01-30 07:53:02]

Committed patchset #3 (id:40001) manually as 43326 (presubmit successful).

[zarah, 2015-01-30 07:53:31]

https://chromiumcodereview.appspot.com/890583003/diff/20001/pkg/compiler/lib/...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://chromiumcodereview.appspot.com/890583003/diff/20001/pkg/compiler/lib/...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:262:
emitter.interceptorEmitter.
On 2015/01/29 20:52:48, floitsch wrote:
> nit: put the "." into the next line.

Done.