Utility process: move GTK initialization to the plugin loading code path.

Utility process: move GTK initialization to the plugin loading code path.

Since GTK initialization loads shared libraries and accesses
the file system, having this code present in every code path
that uses the utility process would prevent us from sandboxing
the uses of the utility process that don't access the filesystem
themselves.

Moreover, since GTK initialization is only used for plugin loading,
which cannot be sandboxed, there is no harm in moving it to the
plugin loading path. We do check that the GTK thread system has not
already been initialized (only needed for glib < 2.24):

http://developer.gnome.org/glib/2.28/glib-Threads.html#g-thread-init

BUG=93109
TEST=Similar to issue 8774048, having libtotem plugins installed,
go to about:plugins and check that they are present.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113904

[Jorge Lucangeli Obes, 2011-12-08 00:05:05]

The inclusion of GTK initialization in all uses of the utility process
conflicted with sandboxing the utility process (GTK initialization landed in the
tree after I rebased but while my patch was in CQ).

Move to the plugin loading code path so that I can reland the sandboxing
changes.

[piman, 2011-12-08 00:35:12]

lgtm

[Jorge Lucangeli Obes, 2011-12-08 23:41:39]

On 2011/12/08 00:35:12, piman wrote:
> lgtm

jam@: just checking whether this fell through the cracks.

[jam, 2011-12-09 01:55:56]

On 2011/12/08 23:41:39, jorgelo wrote:
> On 2011/12/08 00:35:12, piman wrote:
> > lgtm
> 
> jam@: just checking whether this fell through the cracks.

lgtm.  i'm ooo per my autoreply, so please send reviews to other owners in the
meantime

[commit-bot: I haz the power, 2011-12-09 18:27:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/8870005/1

[commit-bot: I haz the power, 2011-12-09 20:46:54]

Try job failure for 8870005-1 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-12-09 23:28:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/8870005/1

[commit-bot: I haz the power, 2011-12-10 00:56:09]

Change committed as 113904