Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 882713008: Move computation of method flags into model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
index 88c5f612ccc7a48d7846d4cbc7267212f3873774..f08b34102cfd8347ebbd47bc5fe84c23800de33c 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
@@ -236,16 +236,16 @@ class ClassEmitter extends CodeEmitterHelper {
if (cls.onlyForRti || cls.isMixinApplication) return;
- void visitMember(ClassElement enclosing, Element member) {
- assert(invariant(classElement, member.isDeclaration));
- if (member.isInstanceMember) {
- emitter.containerBuilder.addMember(member, builder);
- }
+ // TODO(herhut): This is a no-op. Should it be removed?
floitsch 2015/01/28 16:10:39 In a different CL.
herhut 2015/01/29 10:24:21 Acknowledged.
+ for (Field field in cls.fields) {
+ emitter.containerBuilder.addMemberField(field, builder);
}
- classElement.implementation.forEachMember(
- visitMember,
- includeBackendMembers: true);
+ for (Method method in cls.methods) {
+ assert(invariant(classElement, method.element.isDeclaration));
+ assert(invariant(classElement, method.element.isInstanceMember));
+ emitter.containerBuilder.addMemberMethod(method, builder);
+ }
if (identical(classElement, compiler.objectClass)
&& compiler.enabledNoSuchMethod) {

Powered by Google App Engine
This is Rietveld 408576698