Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2214)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 882713008: Move computation of method flags into model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index aaca01c2e28b33b22dfbf32cea97acd92639086b..87b66128e0fe89b32c21c6f952c69a2a5a9a4b33 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -740,14 +740,13 @@ class OldEmitter implements Emitter {
void emitStaticFunctions(Iterable<Method> staticFunctions) {
if (staticFunctions == null) return;
- // We need to filter out null-elements for the interceptors.
- Iterable<Element> elements = staticFunctions
- .where((Method method) => method.element != null)
- .map((Method method) => method.element);
- for (Element element in elements) {
+ for (Method method in staticFunctions) {
+ Element element = method.element;
+ // We need to filter out null-elements for the interceptors.
floitsch 2015/01/28 16:10:39 That works too :) Please add a: TODO(floitsch): u
herhut 2015/01/29 10:24:21 Done.
+ if (element == null) continue;
ClassBuilder builder = new ClassBuilder(element, namer);
- containerBuilder.addMember(element, builder);
+ containerBuilder.addMemberMethod(method, builder);
getElementDescriptor(element).properties.addAll(builder.properties);
}
}

Powered by Google App Engine
This is Rietveld 408576698