scripts/slave/recipe_modules/chromium/config.py - Issue 878923002: Don't set fastbuild=1 for Mac ASan trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 878923002: Don't set fastbuild=1 for Mac ASan trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Move fastbuild=0 to asan() config and retrain Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/config.py

diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py

index c34750a5fe82b2868dcd7feb3904bfb6caaa9969..18a07c64434784f12e48c8da25d0be7d8ad128d0 100644

--- a/scripts/slave/recipe_modules/chromium/config.py

+++ b/scripts/slave/recipe_modules/chromium/config.py

@@ -373,6 +373,9 @@ def asan(c):

'suppressions.txt')

if c.TARGET_PLATFORM == 'linux':

c.gyp_env.GYP_DEFINES['use_allocator'] = 'none'

+ if c.TARGET_PLATFORM == 'mac':

+ # Set fastbuild=0 and prevent other configs from changing it.

+ fastbuild(c, invert=True, optional=False)

c.gyp_env.GYP_DEFINES['asan'] = 1

c.gyp_env.GYP_DEFINES['lsan'] = 1

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json » ('j') | no next file with comments »