Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Side by Side Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 878923002: Don't set fastbuild=1 for Mac ASan trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Move fastbuild=0 to asan() config and retrain Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import pipes 5 import pipes
6 6
7 from slave.recipe_config import config_item_context, ConfigGroup 7 from slave.recipe_config import config_item_context, ConfigGroup
8 from slave.recipe_config import Dict, List, Single, Static, Set, BadConf 8 from slave.recipe_config import Dict, List, Single, Static, Set, BadConf
9 from slave.recipe_config_types import Path 9 from slave.recipe_config_types import Path
10 10
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 c.compile_py.mode = 'official' 366 c.compile_py.mode = 'official'
367 367
368 @config_ctx(deps=['compiler']) 368 @config_ctx(deps=['compiler'])
369 def asan(c): 369 def asan(c):
370 if 'clang' not in c.compile_py.compiler: # pragma: no cover 370 if 'clang' not in c.compile_py.compiler: # pragma: no cover
371 raise BadConf('asan requires clang') 371 raise BadConf('asan requires clang')
372 c.runtests.lsan_suppressions_file = Path('[CHECKOUT]', 'tools', 'lsan', 372 c.runtests.lsan_suppressions_file = Path('[CHECKOUT]', 'tools', 'lsan',
373 'suppressions.txt') 373 'suppressions.txt')
374 if c.TARGET_PLATFORM == 'linux': 374 if c.TARGET_PLATFORM == 'linux':
375 c.gyp_env.GYP_DEFINES['use_allocator'] = 'none' 375 c.gyp_env.GYP_DEFINES['use_allocator'] = 'none'
376 if c.TARGET_PLATFORM == 'mac':
377 # Set fastbuild=0 and prevent other configs from changing it.
378 fastbuild(c, invert=True, optional=False)
376 379
377 c.gyp_env.GYP_DEFINES['asan'] = 1 380 c.gyp_env.GYP_DEFINES['asan'] = 1
378 c.gyp_env.GYP_DEFINES['lsan'] = 1 381 c.gyp_env.GYP_DEFINES['lsan'] = 1
379 382
380 # TODO(infra,earthdok,glider): Make this a gyp variable. This is also not a 383 # TODO(infra,earthdok,glider): Make this a gyp variable. This is also not a
381 # good name as only v8 builds release symbolized with -O2 while 384 # good name as only v8 builds release symbolized with -O2 while
382 # chromium.lkgr uses -O1. 385 # chromium.lkgr uses -O1.
383 @config_ctx() 386 @config_ctx()
384 def asan_symbolized(c): 387 def asan_symbolized(c):
385 c.gyp_env.GYP_DEFINES['release_extra_cflags'] = ( 388 c.gyp_env.GYP_DEFINES['release_extra_cflags'] = (
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 def v8_verify_heap(c): 689 def v8_verify_heap(c):
687 c.gyp_env.GYP_DEFINES['v8_enable_verify_heap'] = 1 690 c.gyp_env.GYP_DEFINES['v8_enable_verify_heap'] = 1
688 691
689 @config_ctx() 692 @config_ctx()
690 def chromium_perf(c): 693 def chromium_perf(c):
691 c.compile_py.clobber = False 694 c.compile_py.clobber = False
692 695
693 @config_ctx() 696 @config_ctx()
694 def chromium_deterministic_build(c): 697 def chromium_deterministic_build(c):
695 c.gyp_env.GYP_DEFINES['dont_embed_build_metadata'] = 1 698 c.gyp_env.GYP_DEFINES['dont_embed_build_metadata'] = 1
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698