Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 858433005: dart2js: Don't reference mixins when they are only used for RTI. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org, sigurdm, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Don't reference mixins when they are only used for RTI. BUG= http://dartbug.com/21896 R=sigurdm@google.com, zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +6 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
floitsch
5 years, 11 months ago (2015-01-16 16:51:51 UTC) #2
floitsch
5 years, 11 months ago (2015-01-16 16:52:05 UTC) #3
sigurdm
lgtm
5 years, 11 months ago (2015-01-19 08:39:22 UTC) #5
zarah
LGTM
5 years, 11 months ago (2015-01-19 09:59:49 UTC) #7
floitsch
5 years, 11 months ago (2015-01-19 13:34:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42990 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698