Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/ui/webui/options/advanced_options_utils_linux.cc

Issue 846753002: Update EnsureProcessGetsReaped to receive a pid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/advanced_options_utils_linux.cc
diff --git a/chrome/browser/ui/webui/options/advanced_options_utils_linux.cc b/chrome/browser/ui/webui/options/advanced_options_utils_linux.cc
index 0f7c4b7e0b265b8cde6c0e34f3e1e5f205e65acf..cda35a1fadcb269f27b4b9fe0c68bf24cce48dc3 100644
--- a/chrome/browser/ui/webui/options/advanced_options_utils_linux.cc
+++ b/chrome/browser/ui/webui/options/advanced_options_utils_linux.cc
@@ -92,12 +92,12 @@ bool StartProxyConfigUtil(const char* command[]) {
std::vector<std::string> argv;
for (size_t i = 0; command[i]; ++i)
argv.push_back(command[i]);
- base::ProcessHandle handle;
- if (!base::LaunchProcess(argv, base::LaunchOptions(), &handle)) {
+ base::Process process = base::LaunchProcess(argv, base::LaunchOptions());
+ if (!process.IsValid()) {
LOG(ERROR) << "StartProxyConfigUtil failed to start " << command[0];
return false;
}
- base::EnsureProcessGetsReaped(handle);
+ base::EnsureProcessGetsReaped(process.pid());
return true;
}

Powered by Google App Engine
This is Rietveld 408576698