Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7953)

Unified Diff: chrome/service/cloud_print/cloud_print_proxy.cc

Issue 846753002: Update EnsureProcessGetsReaped to receive a pid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_proxy.cc
diff --git a/chrome/service/cloud_print/cloud_print_proxy.cc b/chrome/service/cloud_print/cloud_print_proxy.cc
index 60dbb87946af15a9fc40996fe38a8ad49a94d729..ae56186b61d9818604d855f702dcdb2a48d61884 100644
--- a/chrome/service/cloud_print/cloud_print_proxy.cc
+++ b/chrome/service/cloud_print/cloud_print_proxy.cc
@@ -43,9 +43,9 @@ void LaunchBrowserProcessWithSwitch(const std::string& switch_string) {
cmd_line.AppendSwitch(switch_string);
#if defined(OS_POSIX) && !defined(OS_MACOSX)
- base::ProcessHandle pid = 0;
- base::LaunchProcess(cmd_line, base::LaunchOptions(), &pid);
- base::EnsureProcessGetsReaped(pid);
+ base::Process process = base::LaunchProcess(cmd_line, base::LaunchOptions());
+ if (process.IsValid())
+ base::EnsureProcessGetsReaped(process.pid());
#else
base::LaunchOptions launch_options;
#if defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698