V4L2VDA: Generalize EGLImage import and query driver for output formats.

V4L2VDA: Generalize EGLImage import and query driver for output formats.

Generalize CreateEGLImage() from being NV12M-specific to support any
format. Add a method to query whether current platform supports importing
a given V4L2/DRM format into EGLImages and use it in V4L2VDA.
Dynamically query the driver for supported V4L2 output formats and choose
one we can use for EGLImage import.

TEST=Video playback for affected platforms
BUG=chromium:430638, chrome-os-partner:33728, chromium:350197
Committed: https://crrev.com/3b87d51779440abedbf5fd0578b7ea02b988d876
Cr-Commit-Position: refs/heads/master@{#310241}

[Pawel Osciak, 2015-01-06 05:08:19]

posciak@chromium.org changed reviewers:
+ wuchengli@chromium.org

[Pawel Osciak, 2015-01-06 05:08:26]

ptal

[wuchengli, 2015-01-06 06:46:14]

wuchengli@chromium.org changed reviewers:
+ kcwu@chromium.org
- wuchengli@chromium.org

[wuchengli, 2015-01-06 06:46:29]

wuchengli@chromium.org changed reviewers:
+ wuchengli@chromium.org

[wuchengli, 2015-01-06 06:46:29]

Kuang-che will review this one.

[wuchengli, 2015-01-06 08:17:07]

wuchengli@chromium.org changed reviewers:
- wuchengli@chromium.org

[kcwu, 2015-01-06 08:28:52]

https://codereview.chromium.org/839523002/diff/1/content/common/gpu/media/gen...
File content/common/gpu/media/generic_v4l2_video_device.cc (right):

https://codereview.chromium.org/839523002/diff/1/content/common/gpu/media/gen...
content/common/gpu/media/generic_v4l2_video_device.cc:142: static uint32_t
kEGLImageDrmFmtsSupported[] {
= {
"(Uniform) Initialization Syntax" is disallowed according to
http://chromium-cpp.appspot.com/

https://codereview.chromium.org/839523002/diff/1/media/base/video_frame.cc
File media/base/video_frame.cc (right):

https://codereview.chromium.org/839523002/diff/1/media/base/video_frame.cc#ne...
media/base/video_frame.cc:577: int width = RoundUp(coded_size.width(), 2);
Looks like you want to round up conditionally. Did you mean
int width = coded_size.width(); ?

[Pawel Osciak, 2015-01-06 13:09:59]

https://chromiumcodereview.appspot.com/839523002/diff/1/content/common/gpu/me...
File content/common/gpu/media/generic_v4l2_video_device.cc (right):

https://chromiumcodereview.appspot.com/839523002/diff/1/content/common/gpu/me...
content/common/gpu/media/generic_v4l2_video_device.cc:142: static uint32_t
kEGLImageDrmFmtsSupported[] {
On 2015/01/06 08:28:52, kcwu wrote:
> = {
> "(Uniform) Initialization Syntax" is disallowed according to
> http://chromium-cpp.appspot.com/

Oh typo, thanks.

https://chromiumcodereview.appspot.com/839523002/diff/1/media/base/video_fram...
File media/base/video_frame.cc (right):

https://chromiumcodereview.appspot.com/839523002/diff/1/media/base/video_fram...
media/base/video_frame.cc:577: int width = RoundUp(coded_size.width(), 2);
On 2015/01/06 08:28:52, kcwu wrote:
> Looks like you want to round up conditionally. Did you mean
> int width = coded_size.width(); ?

Done.

[Pawel Osciak, 2015-01-06 13:10:32]

posciak@chromium.org changed reviewers:
+ reveman@chromium.org, scherkus@chromium.org

[Pawel Osciak, 2015-01-06 13:10:32]

PTAL

[Pawel Osciak, 2015-01-06 13:11:11]

reveman@: Please cc/resources/video_resource_updater.cc
scherkus@: Please rest.

Thank you.

[Pawel Osciak, 2015-01-06 13:17:40]

Patchset #2 (id:20001) has been deleted

[scherkus (not reviewing), 2015-01-06 21:30:08]

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
File media/base/video_frame.cc (right):

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
media/base/video_frame.cc:97: else if (format == VideoFrame::NV12 && plane ==
VideoFrame::kUVPlane)
no need for elses

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
media/base/video_frame.cc:128: default:
please list all cases explicitly rather than use default

it'll force the next person who touches the enum to update and re-evaluation the
condition -- such as you're doing with ARGB :)

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
File media/base/video_frame.h (right):

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
media/base/video_frame.h:68: FORMAT_MAX = YV24,  // Must always be equal to
largest entry logged.
update this to be ARGB

can you also update the VideoPixelFormat enum in
tools/metrics/histograms/histograms.xml?

[Pawel Osciak, 2015-01-07 01:20:31]

All done, thanks.

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
File media/base/video_frame.cc (right):

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
media/base/video_frame.cc:97: else if (format == VideoFrame::NV12 && plane ==
VideoFrame::kUVPlane)
On 2015/01/06 21:30:08, scherkus wrote:
> no need for elses

Done.

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
media/base/video_frame.cc:128: default:
On 2015/01/06 21:30:07, scherkus wrote:
> please list all cases explicitly rather than use default
> 
> it'll force the next person who touches the enum to update and re-evaluation
the
> condition -- such as you're doing with ARGB :)

Done.

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
File media/base/video_frame.h (right):

https://chromiumcodereview.appspot.com/839523002/diff/40001/media/base/video_...
media/base/video_frame.h:68: FORMAT_MAX = YV24,  // Must always be equal to
largest entry logged.
On 2015/01/06 21:30:08, scherkus wrote:
> update this to be ARGB
> 
> can you also update the VideoPixelFormat enum in
> tools/metrics/histograms/histograms.xml?

Wow, that thing is in dire need of updating, several entries missing. Sorry I
missed the comment myself, but it's a bit inconspicuous... Let's try with this.

[Pawel Osciak, 2015-01-07 01:21:38]

posciak@chromium.org changed reviewers:
+ isherman@chromium.org

[Pawel Osciak, 2015-01-07 01:21:38]

isherman@chromium.org: Please OWNERS for histograms. Thank you.

[reveman, 2015-01-07 01:24:15]

cc lgtm

[Ilya Sherman, 2015-01-07 01:45:49]

histograms.xml lgtm

[scherkus (not reviewing), 2015-01-07 03:33:50]

lgtm

[kcwu1, 2015-01-07 03:36:25]

kcwu@google.com changed reviewers:
+ kcwu@google.com

[kcwu1, 2015-01-07 03:36:26]

lgtm

[Pawel Osciak, 2015-01-07 03:37:54]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2015-01-07 03:38:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839523002/80001

[commit-bot: I haz the power, 2015-01-07 03:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-07 03:47:26]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Pawel Osciak, 2015-01-07 03:54:28]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2015-01-07 03:55:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839523002/100001

[commit-bot: I haz the power, 2015-01-07 03:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-07 03:58:26]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Pawel Osciak, 2015-01-07 04:32:18]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2015-01-07 04:32:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839523002/120001

[commit-bot: I haz the power, 2015-01-07 04:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-07 04:44:21]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Pawel Osciak, 2015-01-07 05:28:34]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2015-01-07 05:29:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839523002/140001

[commit-bot: I haz the power, 2015-01-07 06:38:31]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2015-01-07 06:39:24]

Patchset 7 (id:??) landed as
https://crrev.com/3b87d51779440abedbf5fd0578b7ea02b988d876
Cr-Commit-Position: refs/heads/master@{#310241}

[Pawel Osciak, 2015-01-10 01:01:15]

Patchset #8 (id:160001) has been deleted