added front page samples to testing, plus a couple of tweaks to front page and code lab

added front page samples to testing, plus a couple of tweaks to front page and code lab

BUG=
R=kathyw@google.com

Committed: fdd3162

[mem, 2013-11-23 00:17:31]

Put front page samples under testing. tweaked some text.

Fixed the carousel height! Yay for that.

View it here:
https://mem-codetests-fixes-dot-dart-lang.appspot.com/

mem

[Kathy Walrath, 2013-11-23 00:46:27]

Looks good. Some suggested tweaks.

Oh, and shouldn't we delete src/tests/site/futures.dart?

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
File src/tests/site/code/die.dart (right):

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
src/tests/site/code/die.dart:3: void main() {                          // This
is where the app starts executing.
Ew. > 80 characters. Oh well.

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
File src/tests/site/code/syntax.dart (right):

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
src/tests/site/code/syntax.dart:16: abstract class Shape {
Why is this still in here?

Oh... I didn't notice that the sample still uses rotation, color, and
outlineWidth, which are defined by Shape.

We should probably change the sample on the page so that class Ellipse extends
Shape.

(We don't need to show Shape.)

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
src/tests/site/code/syntax.dart:29: static const num C = PI/4;              // A
constant.
Get rid of code that isn't already on the front page (or referred to indirectly
by the front page).

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
src/tests/site/code/syntax.dart:30: num get area => C*majorAxis*minorAxis;  // A
property implemented with a getter.
Should show this on the front page. It seems like there's room, and you refer to
it.

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
File src/tests/site/code/types_no.dart (right):

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/tests/site/cod...
src/tests/site/code/types_no.dart:1: //import 'dart:math' show Point;
Why have this line in the test?

[Kathy Walrath, 2013-11-23 00:51:53]

Forgot a couple...

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/site/codelabs/...
File src/site/codelabs/darrrt/index.markdown (right):

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/site/codelabs/...
src/site/codelabs/darrrt/index.markdown:22: ## Got about an hour? Write a Dart
app.
As we discussed, delete this line entirely.

https://chromiumcodereview.appspot.com/83663005/diff/30001/src/site/codelabs/...
src/site/codelabs/darrrt/index.markdown:38: <div class="piratemap" markdown="1"
style="min-height:325px">

I've asked the artist to remove "Try" from the map.

[mem, 2013-11-25 18:32:50]

PTAL

[Kathy Walrath, 2013-11-25 19:08:41]

lgtm

[mem, 2013-11-25 19:15:54]

Committed patchset #5 manually as rfdd3162 (presubmit successful).