chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java ('k') | chrome/browser/android/chrome_web_contents_delegate_android.cc » ('j') | chrome/browser/android/content_view_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java

index bc6deeb48cfce949193df96b5742fa5b5abc87be..f6f7a38e0f8cfd466bff6469b19daf516fbc8a5b 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java

@@ -8,6 +8,7 @@ import org.chromium.chrome.browser.Tab;

import org.chromium.chrome.browser.tabmodel.TabModelBase;

import org.chromium.chrome.browser.tabmodel.TabModelDelegate;

import org.chromium.chrome.browser.tabmodel.TabModelOrderController;

+import org.chromium.content_public.browser.WebContents;

/**

* Basic implementation of TabModel for use in ChromeShell.

@@ -20,7 +21,7 @@ public class ChromeShellTabModel extends TabModelBase {

}

@Override

- protected Tab createTabWithNativeContents(boolean incognito, long nativeWebContents,

+ protected Tab createTabWithWebContents(boolean incognito, WebContents webContents,

int parentId) {

return null;

}