chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModel.java » ('j') | chrome/browser/android/content_view_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

index c04f6d032ae76de0fab36906e7ede57af1ad52a3..c0bd1ce9291c0d96eb211ca6fbec52ee803e32e0 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

@@ -40,7 +40,7 @@ public class ChromeShellTab extends Tab {

public ChromeShellTab(Context context, LoadUrlParams params, WindowAndroid window,

ContentViewClient contentViewClient, TabManager tabManager) {

super(false, context, window);

- initialize(0, null, false);

+ initialize(null, null, false);

mTabManager = tabManager;

setContentViewClient(contentViewClient);

loadUrl(params);

@@ -141,8 +141,8 @@ public class ChromeShellTab extends Tab {

}

@Override

- public void webContentsCreated(long sourceWebContents, long openerRenderFrameId,

- String frameName, String targetUrl, long newWebContents) {

+ public void webContentsCreated(WebContents sourceWebContents, long openerRenderFrameId,

+ String frameName, String targetUrl, WebContents newWebContents) {

mTabManager.createTab(targetUrl, TabLaunchType.FROM_LINK);

super.webContentsCreated(

sourceWebContents, openerRenderFrameId, frameName, targetUrl, newWebContents);