chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java » ('j') | chrome/browser/android/content_view_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

index d13767f0eee352877f851575a9e7a346eaee68cf..e8c91b0870db28434f88a7cd0c4ab79b67dafe48 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java

@@ -17,6 +17,7 @@ import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;

import org.chromium.content.browser.test.NativeLibraryTestBase;

import org.chromium.content_public.browser.LoadUrlParams;

+import org.chromium.content_public.browser.WebContents;

import org.chromium.ui.base.WindowAndroid;

/**

@@ -90,7 +91,7 @@ public class TabModelSelectorTabObserverTest extends NativeLibraryTestBase {

};

mNormalTabModel = new TabModelBase(false, orderController, delegate) {

@Override

- protected Tab createTabWithNativeContents(boolean incognito, long nativeWebContents,

+ protected Tab createTabWithWebContents(boolean incognito, WebContents webContents,

int parentId) {

return null;

}

@@ -103,7 +104,7 @@ public class TabModelSelectorTabObserverTest extends NativeLibraryTestBase {

mIncognitoTabModel = new TabModelBase(true, orderController, delegate) {

@Override

- protected Tab createTabWithNativeContents(boolean incognito, long nativeWebContents,

+ protected Tab createTabWithWebContents(boolean incognito, WebContents webContents,

int parentId) {

return null;

}