chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java » ('j') | chrome/browser/android/content_view_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

index 0260c27ec3384a3a340ab7a0ab750f19ac7c2081..35d7638f28ddb747c999e4998a0b7c99d5275118 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

@@ -10,6 +10,7 @@ import org.chromium.chrome.browser.Tab;

import org.chromium.chrome.browser.document.PendingDocumentData;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModel.Entry;

import org.chromium.content_public.browser.LoadUrlParams;

+import org.chromium.content_public.browser.WebContents;

/**

* Provides Tabs to a DocumentTabModel.

@@ -42,10 +43,10 @@ public interface TabDelegate {

/**

* Creates a new Activity for the pre-created WebContents.

* @param isIncognito Whether the Activity is supposed to hold an incognito Tab.

- * @param webContentsPtr Native-side WebContents pointer to use for the new Tab.

+ * @param webContents WebContents to use with the new Tab.

* @param parentTabId ID of the spawning Tab.

- void createTabWithNativeContents(boolean isIncognito, long webContentsPtr, int parentTabId);

+ void createTabWithWebContents(boolean isIncognito, WebContents webContents, int parentTabId);

/**

* Creates a new Tab for a URL typed into DevTools.