chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java - Issue 831523005: Remove most native WebContents references from Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept same error checking behavior for aw_contents.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java » ('j') | chrome/browser/android/content_view_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

index 6736325334a6948ec3f3b79f78ae5815960d917f..cdba4f01c1114a3e55ef64871a0cadeb1cc49f66 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

@@ -32,6 +32,7 @@ import org.chromium.chrome.browser.tabmodel.TabModelUtils;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModelInfo.DocumentEntry;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModelInfo.DocumentList;

import org.chromium.chrome.browser.util.MathUtils;

+import org.chromium.content_public.browser.WebContents;

import java.io.File;

import java.io.IOException;

@@ -318,9 +319,9 @@ public class DocumentTabModelImpl extends TabModelJniBridge implements DocumentT

}

@Override

- protected Tab createTabWithNativeContents(

- boolean isIncognito, long webContentsPtr, int parentTabId) {

- mTabDelegate.createTabWithNativeContents(isIncognito, webContentsPtr, parentTabId);

+ protected Tab createTabWithWebContents(

+ boolean isIncognito, WebContents webContents, int parentTabId) {

+ mTabDelegate.createTabWithWebContents(isIncognito, webContents, parentTabId);

return null;

}