Update Android Card Unmask prompt to rely on the controller a bit more.

Update Android Card Unmask prompt to rely on the controller a bit more.

BUG=437116
Committed: https://crrev.com/774d92b9ab2d08b34dde434b06f00b472de175b7
Cr-Commit-Position: refs/heads/master@{#310178}

[Evan Stade, 2014-12-31 00:13:34]

estade@chromium.org changed reviewers:
+ aurimas@chromium.org

[aurimas (slooooooooow), 2015-01-06 21:19:46]

lgtm

https://chromiumcodereview.appspot.com/828063004/diff/40001/ui/android/java/s...
File ui/android/java/src/org/chromium/ui/autofill/CardUnmaskPrompt.java (right):

https://chromiumcodereview.appspot.com/828063004/diff/40001/ui/android/java/s...
ui/android/java/src/org/chromium/ui/autofill/CardUnmaskPrompt.java:84:
input.post(new Runnable() {
Why do we post a runnable? showSoftInput should not take long.

[Evan Stade, 2015-01-06 22:11:11]

https://chromiumcodereview.appspot.com/828063004/diff/40001/ui/android/java/s...
File ui/android/java/src/org/chromium/ui/autofill/CardUnmaskPrompt.java (right):

https://chromiumcodereview.appspot.com/828063004/diff/40001/ui/android/java/s...
ui/android/java/src/org/chromium/ui/autofill/CardUnmaskPrompt.java:84:
input.post(new Runnable() {
On 2015/01/06 21:19:46, aurimas wrote:
> Why do we post a runnable? showSoftInput should not take long.

it has to happen some short amount of time after show() is called. Same story as
AddEditBookmarkFragment.

[Evan Stade, 2015-01-06 22:15:28]

estade@chromium.org changed reviewers:
+ newt@chromium.org

[Evan Stade, 2015-01-06 22:15:29]

+newt for xml and grd OWNERship

[newt (away), 2015-01-06 22:19:40]

lgtm after string description is updated

https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
File ui/android/java/strings/android_ui_strings.grd (right):

https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
ui/android/java/strings/android_ui_strings.grd:220: <message
desc="Placeholder/hint text for the CVC input in the card unmasking prompt."
name="IDS_CARD_UNMASK_INPUT_HINT">
Side-comment: This description is not sufficient for translators.

[Evan Stade, 2015-01-06 22:23:55]

https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
File ui/android/java/strings/android_ui_strings.grd (right):

https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
ui/android/java/strings/android_ui_strings.grd:220: <message
desc="Placeholder/hint text for the CVC input in the card unmasking prompt."
name="IDS_CARD_UNMASK_INPUT_HINT">
On 2015/01/06 22:19:40, newt wrote:
> Side-comment: This description is not sufficient for translators. 

How would you like to see it improved? I think "placeholder/hint text for the
CVC input" plus the English version ("CVC") should be enough. Extra context
about what the dialog is used for is not going to be relevant.

[newt (away), 2015-01-06 22:30:53]

On 2015/01/06 22:23:55, Evan Stade wrote:
>
https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
> File ui/android/java/strings/android_ui_strings.grd (right):
> 
>
https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
> ui/android/java/strings/android_ui_strings.grd:220: <message
> desc="Placeholder/hint text for the CVC input in the card unmasking prompt."
> name="IDS_CARD_UNMASK_INPUT_HINT">
> On 2015/01/06 22:19:40, newt wrote:
> > Side-comment: This description is not sufficient for translators. 
> 
> How would you like to see it improved? I think "placeholder/hint text for the
> CVC input" plus the English version ("CVC") should be enough. Extra context
> about what the dialog is used for is not going to be relevant.

I wouldn't expect translators to have the slightest clue what "card unmasking"
means.

How about this: "Hint text for an input field containing the user's credit card
CVC (card verification code)".

[Evan Stade, 2015-01-06 22:52:41]

On 2015/01/06 22:30:53, newt wrote:
> On 2015/01/06 22:23:55, Evan Stade wrote:
> >
>
https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
> > File ui/android/java/strings/android_ui_strings.grd (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/828063004/diff/60001/ui/android/java/s...
> > ui/android/java/strings/android_ui_strings.grd:220: <message
> > desc="Placeholder/hint text for the CVC input in the card unmasking prompt."
> > name="IDS_CARD_UNMASK_INPUT_HINT">
> > On 2015/01/06 22:19:40, newt wrote:
> > > Side-comment: This description is not sufficient for translators. 
> > 
> > How would you like to see it improved? I think "placeholder/hint text for
the
> > CVC input" plus the English version ("CVC") should be enough. Extra context
> > about what the dialog is used for is not going to be relevant.
> 
> I wouldn't expect translators to have the slightest clue what "card unmasking"
> means.
> 
> How about this: "Hint text for an input field containing the user's credit
card
> CVC (card verification code)".

done

[Evan Stade, 2015-01-06 22:52:47]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-06 22:53:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/828063004/80001

[commit-bot: I haz the power, 2015-01-07 00:02:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-07 00:03:07]

Patchset 5 (id:??) landed as
https://crrev.com/774d92b9ab2d08b34dde434b06f00b472de175b7
Cr-Commit-Position: refs/heads/master@{#310178}