Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2474)

Unified Diff: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc

Issue 828063004: Update Android Card Unmask prompt to rely on the controller a bit more. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use newt's description Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
index 3e3230e2fa9d9278da4aa133f6ad4dcf401329c5..f286813f3a96e788737f1ff0a7ba4f3a83a9de7e 100644
--- a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
+++ b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
@@ -35,13 +35,27 @@ void CardUnmaskPromptViewAndroid::Show() {
ui::ViewAndroid* view_android =
controller_->GetWebContents()->GetNativeView();
+ ScopedJavaLocalRef<jstring> dialog_title =
+ base::android::ConvertUTF16ToJavaString(env,
+ controller_->GetWindowTitle());
+ ScopedJavaLocalRef<jstring> instructions =
+ base::android::ConvertUTF16ToJavaString(
+ env, controller_->GetInstructionsMessage());
java_object_.Reset(Java_CardUnmaskBridge_create(
- env, reinterpret_cast<intptr_t>(this),
+ env, reinterpret_cast<intptr_t>(this), dialog_title.obj(),
+ instructions.obj(),
view_android->GetWindowAndroid()->GetJavaObject().obj()));
Java_CardUnmaskBridge_show(env, java_object_.obj());
}
+bool CardUnmaskPromptViewAndroid::CheckUserInputValidity(JNIEnv* env,
+ jobject obj,
+ jstring response) {
+ return controller_->InputTextIsValid(
+ base::android::ConvertJavaStringToUTF16(env, response));
+}
+
void CardUnmaskPromptViewAndroid::OnUserInput(JNIEnv* env,
jobject obj,
jstring response) {
@@ -65,12 +79,8 @@ void CardUnmaskPromptViewAndroid::DisableAndWaitForVerification() {
}
void CardUnmaskPromptViewAndroid::GotVerificationResult(bool success) {
- if (success) {
- // TODO(estade): implement.
- } else {
- JNIEnv* env = base::android::AttachCurrentThread();
- Java_CardUnmaskBridge_verificationFailed(env, java_object_.obj());
- }
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_CardUnmaskBridge_verificationFinished(env, java_object_.obj(), success);
}
// static

Powered by Google App Engine
This is Rietveld 408576698