Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 818853005: Store NavigationEntryImpl data into NavigationRequest for later usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed respective TODOs. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index c680cb199fecf72ebc900ce25a3088608063a288..d3fdb909f31d6086dd40ca0a63fd478b941349aa 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -783,7 +783,7 @@ void NavigatorImpl::OnBeginNavigation(
// Then notify the RenderFrameHostManager so it can speculatively create a
// RenderFrameHost (and potentially a new renderer process) in parallel.
- frame_tree_node->render_manager()->BeginNavigation(common_params);
+ frame_tree_node->render_manager()->BeginNavigation(navigation_request);
}
// PlzNavigate
@@ -809,8 +809,7 @@ void NavigatorImpl::CommitNavigation(FrameTreeNode* frame_tree_node,
// Select an appropriate renderer to commit the navigation.
RenderFrameHostImpl* render_frame_host =
frame_tree_node->render_manager()->GetFrameHostForNavigation(
- navigation_request->common_params().url,
- navigation_request->common_params().transition);
+ navigation_request);
CheckWebUIRendererDoesNotDisplayNormalURL(
render_frame_host, navigation_request->common_params().url);
@@ -895,6 +894,7 @@ bool NavigatorImpl::RequestNavigation(
CommitNavigationParams(entry.GetPageState(),
entry.GetIsOverridingUserAgent(),
navigation_start)));
+ navigation_request->CopyDataFrom(entry);
clamy 2015/01/16 16:39:02 Considering that we only call CopyDataFrom once, j
carlosk 2015/01/19 15:02:52 Done.
RequestNavigationParams request_params(entry.GetHasPostData(),
entry.extra_headers(),
entry.GetBrowserInitiatedPostData());

Powered by Google App Engine
This is Rietveld 408576698