Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 818853005: Store NavigationEntryImpl data into NavigationRequest for later usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed respective TODOs. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index cf6c54421c68e92f438309872c9f0fa6b158e90d..63b27004743a83579107023a8618e20687b65db8 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -31,6 +31,7 @@ class InterstitialPageImpl;
class NavigationControllerImpl;
class NavigationEntry;
class NavigationEntryImpl;
+class NavigationRequest;
class NavigatorTestWithBrowserSideNavigation;
class RenderFrameHost;
class RenderFrameHostDelegate;
@@ -372,15 +373,14 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// PlzNavigate
// Notifies the RFHM that a navigation has begun so that it can speculatively
// create a new RenderFrameHost (and potentially a new process) if needed.
- void BeginNavigation(const CommonNavigationParams& common_params);
+ void BeginNavigation(NavigationRequest* request);
// PlzNavigate
// Called (possibly several times) during a navigation to select or create an
// appropriate RenderFrameHost for the provided URL. The returned pointer will
// be for the current or the speculative RenderFrameHost and the instance is
// owned by this manager.
- RenderFrameHostImpl* GetFrameHostForNavigation(const GURL& url,
- ui::PageTransition transition);
+ RenderFrameHostImpl* GetFrameHostForNavigation(NavigationRequest* request);
// PlzNavigate
// Clean up any state for any ongoing navigation.

Powered by Google App Engine
This is Rietveld 408576698