Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5039)

Unified Diff: app/handlers/api/package_versions.py

Issue 815973002: Remove legacy Package.uploaders PackageVersion.{uploader,readme,changelog} properties (Closed) Base URL: https://github.com/dart-lang/pub-dartlang.git@master
Patch Set: Small fix in changelog/readme handling for new uploads Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/handlers/api/package_uploaders.py ('k') | app/handlers/package_uploaders.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/handlers/api/package_versions.py
diff --git a/app/handlers/api/package_versions.py b/app/handlers/api/package_versions.py
index 1807ff3c21616503bcf00b6e2d68d571b458c935..9397601a9b5fc7f15606efe5e7fdf9addc164074 100644
--- a/app/handlers/api/package_versions.py
+++ b/app/handlers/api/package_versions.py
@@ -79,7 +79,7 @@ class PackageVersions(object):
try:
with closing(cloud_storage.read('tmp/' + id)) as f:
version = PackageVersion.from_archive(
- f, uploader=handlers.get_oauth_user())
+ f, uploaderEmail=handlers.get_oauth_user().email())
except (KeyError, files.ExistenceError):
handlers.http_error(
403, "Package upload " + id + " does not exist.")
@@ -87,7 +87,8 @@ class PackageVersions(object):
# If the package for this version already exists, make sure we're an
# uploader for it. If it doesn't, we're fine to create it anew.
if version.package.is_saved():
- if not version.package.has_uploader(handlers.get_oauth_user()):
+ if not version.package.has_uploader_email(
+ handlers.get_oauth_user().email()):
handlers.http_error(
403, "You aren't an uploader for package '%s'." %
version.package.name)
@@ -106,9 +107,7 @@ class PackageVersions(object):
copy_source='tmp/' + id)
with models.transaction():
- version.package.temp_synchronize_uploaders_to_uploaderemails()
version.package.put()
- version.temp_synchronize_uploader_to_uploaderemail_and_pickles()
version.put()
version.package.invalidate_cache()
« no previous file with comments | « app/handlers/api/package_uploaders.py ('k') | app/handlers/package_uploaders.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698