Remove legacy Package.uploaders PackageVersion.{uploader,readme,changelog} properties

app/handlers/api/package_versions.py

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 from cStringIO import StringIO
 from contextlib import closing
 from uuid import uuid4
 import json
 import logging
 import time
@@ skipping 61 matching lines @@
           id: The id of the package in cloud storage.
         """
 
         try:
             route = handlers.request().route
             if 'id' in route: del route['id']
 
             try:
                 with closing(cloud_storage.read('tmp/' + id)) as f:
                     version = PackageVersion.from_archive(
-                        f, uploader=handlers.get_oauth_user())
+                        f, uploaderEmail=handlers.get_oauth_user().email())
             except (KeyError, files.ExistenceError):
                 handlers.http_error(
                     403, "Package upload " + id + " does not exist.")
 
             # If the package for this version already exists, make sure we're an
             # uploader for it. If it doesn't, we're fine to create it anew.
             if version.package.is_saved():
-                if not version.package.has_uploader(handlers.get_oauth_user()):
+                if not version.package.has_uploader_email(
+                    handlers.get_oauth_user().email()):
                     handlers.http_error(
                         403, "You aren't an uploader for package '%s'." %
                                  version.package.name)
                 elif version.package.has_version(version.version):
                     message = 'Package "%s" already has version "%s".' % \
                         (version.package.name, version.version)
                     handlers.http_error(400, message)
 
                 if self._should_update_latest_version(version):
                     version.package.latest_version = version
             else:
                 version.package.latest_version = version
 
             cloud_storage.modify_object(version.storage_path,
                                         acl='public-read',
                                         copy_source='tmp/' + id)
 
             with models.transaction():
-                version.package.temp_synchronize_uploaders_to_uploaderemails()
                 version.package.put()
-                version.temp_synchronize_uploader_to_uploaderemail_and_pickles()
                 version.put()
                 version.package.invalidate_cache()
 
             deferred.defer(self._compute_version_order, version.package.name)
 
             return handlers.json_success('%s %s uploaded successfully.' %
                 (version.package.name, version.version))
         finally:
             cloud_storage.delete_object('tmp/' + id)
 
@@ skipping 59 matching lines @@
     @handlers.requires_oauth_key
     @handlers.requires_uploader
     def new_dartdoc(self, package_id, id):
         """Retrieve the form for uploading dartdoc for this package version."""
         version = handlers.request().package_version(id)
         upload = cloud_storage.Upload(version.dartdoc_storage_path,
                                       acl='public-read',
                                       size_range=(0, Package.MAX_SIZE))
 
         return upload.to_json()