Protobuf changes for smaller dart2js code, Int64 fixes

lib/message_generator.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of protoc;
 
 const String SP = ' ';
 
 class MessageGenerator extends ProtobufContainer {
   // List of Dart language reserved words in names which cannot be used in a
@@ skipping 87 matching lines @@
           ';', () {
         for (ProtobufField field in _fieldList) {
           String type = field.shortTypeName;
           String fieldType = field.baseTypeForPackage(package);
 
           String makeDefault = null;
           if (field.hasInitialization) {
             makeDefault = field.initializationForPackage(package);
           }
           String subBuilder = null;
-          if (field.message || field.group) {
+          String subBuilderRepeated = null;
+          if (field.message) {
+            subBuilder = '${fieldType}.create';
+            subBuilderRepeated = '${fieldType}.createRepeated';
+          } else if (field.group) {

[Siggi Cherem (dart-lang), 2014/12/19 21:53:14]

after chatting about it - seems we can do the same here for groups too

[sra1, 2014/12/19 23:11:02]

Done.

             subBuilder = '()${SP}=>${SP}new ${fieldType}()';
+            subBuilderRepeated = '()${SP}=>${SP}new PbList<${fieldType}>()';

[Siggi Cherem (dart-lang), 2014/12/19 21:53:14]

not for this CL, but I'll ask since I'm thinking about it here. I haven't read
this code in a long time - any reason why we are using $SP at all? it seems just
noise... 

Søren - do you know of any reasons for it?

[Søren Gjesse, 2015/01/05 16:00:07]

I don't see any reason for using ${SP} when generating the code. I think this
dates back several years, and everybody (including me) have just kept that
style. I will be great to just change it to spaces.

           }
           String valueOf = null;
           if (field.enm) {
             valueOf = '(var v)${SP}=>${SP}${fieldType}.valueOf(v)';
           }
           if ('PM' == type) {
             // Repeated message: default is an empty list
             out.println('..m(${field.number},${SP}'
                 '\'${field.externalFieldName}\',${SP}$subBuilder,'
-                '${SP}()${SP}=>${SP}new PbList<${fieldType}>())');
+                '${SP}$subBuilderRepeated)');
           } else if (type[0] == 'P' && type != 'PG' && type != 'PE') {
             // Repeated, not a message or enum: default is an empty list,
             // subBuilder is null, valueOf is null.
             out.println('..p(${field.number},${SP}'
                 '\'${field.externalFieldName}\',${SP}GeneratedMessage.$type)');
           } else if (type == 'OE' || type == 'QE') {
             out.println('..e(${field.number},${SP}'
                 '\'${field.externalFieldName}\',${SP}GeneratedMessage.$type,'
                 '${SP}$makeDefault,${SP}$valueOf)');
           } else {
@@ skipping 35 matching lines @@
           '${SP}[ExtensionRegistry r = ExtensionRegistry.EMPTY])'
           '${SP}:${SP}super.fromBuffer(i,${SP}r);');
       out.println('${classname}.fromJson(String i,'
           '${SP}[ExtensionRegistry r = ExtensionRegistry.EMPTY])'
           '${SP}:${SP}super.fromJson(i,${SP}r);');
       out.println('${classname} clone()${SP}=>'
           '${SP}new ${classname}()..mergeFromMessage(this);');
 
       out.println('BuilderInfo get info_${SP}=>${SP}_i;');
 
+      // Factory functions which can be used as default value closures.
+      out.println('static ${classname}${SP}create()${SP}=>'
+          '${SP}new ${classname}();');
+      out.println('static PbList<${classname}>${SP}createRepeated()${SP}=>'
+          '${SP}new PbList<${classname}>();');
+
       generateFieldsAccessorsMutators(out);
     });
     out.println();
   }
 
   // Returns true if the message type has any required fields.  If it doesn't,
   // we can optimize out calls to its isInitialized()/_findInvalidFields()
   // methods.
   //
   // already_seen is used to avoid checking the same type multiple times
@@ skipping 65 matching lines @@
             '(${fieldTypeString} v)${SP}'
             '{${SP}setField(${field.number},${SP}v);${SP}}');
         out.println('bool $hasIdentifier()${SP}=>'
             '${SP}hasField(${field.number});');
         out.println('void $clearIdentifier()${SP}=>'
             '${SP}clearField(${field.number});');
       }
     }
   }
 }