Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 79573003: Upstreaming AppMenu. (Closed)

Created:
7 years, 1 month ago by aurimas (slooooooooow)
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Upstreaming AppMenu. Upstreaming the code for handing and showing the menu in Chrome. Start using this AppMenu for ChromiumTestShell. BUG=309517 R=dtrainor@chromium.org, tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237446

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 10

Patch Set 3 : dtrainor's nits #

Patch Set 4 : Rebase #

Patch Set 5 : #

Patch Set 6 : Fixed menu button background #

Patch Set 7 : Enable draggable menu #

Patch Set 8 : Added missing tvdpi back asset #

Patch Set 9 : Actually add tvdpi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1774 lines, -111 lines) Patch
A + chrome/android/java/res/drawable-ldrtl/back_button_selector.xml View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A + chrome/android/java/res/drawable-ldrtl/forward_button_selector.xml View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A chrome/android/java/res/drawable-tvdpi/back.png View 5 6 7 8 Binary file 0 comments Download
A chrome/android/java/res/drawable-tvdpi/back_disabled.png View 5 6 7 8 Binary file 0 comments Download
A + chrome/android/java/res/drawable/back_button_selector.xml View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A + chrome/android/java/res/drawable/forward_button_selector.xml View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A chrome/android/java/res/layout/menu_icon_row.xml View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/menu_item.xml View 1 chunk +32 lines, -0 lines 0 comments Download
A + chrome/android/java/res/values-hdpi/dimens.xml View 1 chunk +3 lines, -2 lines 0 comments Download
A + chrome/android/java/res/values-sw600dp/dimens.xml View 1 chunk +5 lines, -4 lines 0 comments Download
A + chrome/android/java/res/values-xhdpi/dimens.xml View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/values.xml View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/UmaBridge.java View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 2 1 chunk +1005 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java View 1 chunk +108 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java View 1 2 1 chunk +164 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuObserver.java View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/util/KeyNavigationUtil.java View 1 chunk +86 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java View 1 2 3 8 chunks +70 lines, -25 lines 0 comments Download
M chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java View 1 2 3 4 5 6 8 chunks +21 lines, -35 lines 0 comments Download
M chrome/android/testshell/res/layout/testshell_activity.xml View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/android/testshell/res/menu/main_menu.xml View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + chrome/browser/android/uma_bridge.h View 1 chunk +5 lines, -4 lines 0 comments Download
A chrome/browser/android/uma_bridge.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
Hey Dave, Please take a look at this CL. Thanks, Aurimas
7 years, 1 month ago (2013-11-21 01:04:32 UTC) #1
aurimas (slooooooooow)
On 2013/11/21 01:04:32, aurimas wrote: > Hey Dave, > > Please take a look at ...
7 years, 1 month ago (2013-11-22 17:46:15 UTC) #2
David Trainor- moved to gerrit
https://chromiumcodereview.appspot.com/79573003/diff/200001/chrome/android/java/res/drawable-ldrtl/back_button_selector.xml File chrome/android/java/res/drawable-ldrtl/back_button_selector.xml (right): https://chromiumcodereview.appspot.com/79573003/diff/200001/chrome/android/java/res/drawable-ldrtl/back_button_selector.xml#newcode3 chrome/android/java/res/drawable-ldrtl/back_button_selector.xml:3: <!-- Copyright (c) 2011 The Chromium Authors. All rights ...
7 years ago (2013-11-25 18:25:20 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/79573003/diff/200001/chrome/android/java/res/drawable-ldrtl/back_button_selector.xml File chrome/android/java/res/drawable-ldrtl/back_button_selector.xml (right): https://chromiumcodereview.appspot.com/79573003/diff/200001/chrome/android/java/res/drawable-ldrtl/back_button_selector.xml#newcode3 chrome/android/java/res/drawable-ldrtl/back_button_selector.xml:3: <!-- Copyright (c) 2011 The Chromium Authors. All rights ...
7 years ago (2013-11-26 00:15:38 UTC) #4
aurimas (slooooooooow)
Please take another look.
7 years ago (2013-11-26 17:47:57 UTC) #5
David Trainor- moved to gerrit
lgtm
7 years ago (2013-11-26 18:30:46 UTC) #6
aurimas (slooooooooow)
+tedchoc for owners of chrome/browser/android/*
7 years ago (2013-11-26 21:03:12 UTC) #7
Ted C
On 2013/11/26 21:03:12, aurimas wrote: > +tedchoc for owners of chrome/browser/android/* lgtm - chrome/browser/android
7 years ago (2013-11-27 00:06:28 UTC) #8
aurimas (slooooooooow)
7 years ago (2013-11-27 00:10:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #9 manually as r237446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698