chrome/android/testshell/res/menu/main_menu.xml - Issue 79573003: Upstreaming AppMenu.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/testshell/res/menu/main_menu.xml

Issue 79573003: Upstreaming AppMenu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('K') | « chrome/android/testshell/res/layout/testshell_activity.xml ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <menu xmlns:android="http://schemas.android.com/apk/res/android">	8 <menu xmlns:android="http://schemas.android.com/apk/res/android">
	David Trainor- moved to gerrit 2013/11/25 18:25:21 Does this guy get used? Does this guy get used? aurimas (slooooooooow) 2013/11/26 00:15:38 Yes, this is the only one that gets used. Deleted Show quoted text On 2013/11/25 18:25:21, David Trainor wrote: > Does this guy get used? Yes, this is the only one that gets used. Deleted the other main_menu.xml
9 <group android:id="@+id/MAIN_MENU"	9 <group android:id="@+id/MAIN_MENU"

10 android:visible="false">	10 android:visible="false">

11 <item android:id="@+id/signin"	11 <item android:id="@+id/signin"

12 android:title="@string/signin_sign_in" />	12 android:title="@string/signin_sign_in" />

13 </group>	13 </group>

	14

	15 <group android:id="@+id/PHONE_ICON_MENU_ITEMS"

	16 android:visible="false">

	17 <!-- These items are never made visible in the default list. They are on ly used

	18 to pass through the clicks from the icon row in the custom menu. -- >

	19 <item android:id="@+id/back_menu_id"

	20 android:title="@null" />

	21 <item android:id="@+id/forward_menu_id"

	22 android:title="@null" />

	23 <item android:id="@+id/bookmark_this_page_id"

	24 android:title="@null" />

	25 </group>

14 </menu>	26 </menu>

15	27

OLD	NEW