Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 790013002: Make StringBuffer.write easier to inline (Closed)

Created:
6 years ago by sra1
Modified:
6 years ago
Reviewers:
floitsch, herhut
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make StringBuffer.write easier to inline When combined with trivial dead store elimination (https://chromiumcodereview.appspot.com/780403003/), converts more StringBuffers into local variables. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/js_lib/core_patch.dart View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sra1
6 years ago (2014-12-10 00:16:53 UTC) #2
sra1
6 years ago (2014-12-10 20:08:03 UTC) #4
floitsch
LGTM.
6 years ago (2014-12-10 20:28:22 UTC) #5
sra1
6 years ago (2014-12-10 22:48:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42269 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698