Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 789643005: PlzNavigate: make content unit tests work with browser side navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancel-navigations
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 720235227365ec2a878d20f71b2ef2cba69e3af9..745d43c28c62ef75d21081077979ead600b69224 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -241,9 +241,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
// active RenderFrames, but not until WasSwappedOut is called.
void SwapOut(RenderFrameProxyHost* proxy, bool is_loading);
- bool is_waiting_for_beforeunload_ack() const {
- return is_waiting_for_beforeunload_ack_;
- }
+ // Whether an ongoing navigation is waiting for a BeforeUnload ACK from the
+ // renderer. Currently this only happens in cross-site navigations.
nasko 2015/01/17 00:22:01 nit: s/renderer/RenderFrame/
clamy 2015/01/19 17:29:20 Done.
+ // PlzNavigate: this happens in every navigation that is not same-page.
+ bool IsWaitingForBeforeUnloadACK() const;
// Whether the RFH is waiting for an unload ACK from the renderer.
bool IsWaitingForUnloadACK() const;

Powered by Google App Engine
This is Rietveld 408576698