Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 789643005: PlzNavigate: make content unit tests work with browser side navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancel-navigations
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 234
235 // Tells the renderer that this RenderFrame is being swapped out for one in a 235 // Tells the renderer that this RenderFrame is being swapped out for one in a
236 // different renderer process. It should run its unload handler and move to 236 // different renderer process. It should run its unload handler and move to
237 // a blank document. If |proxy| is not null, it should also create a 237 // a blank document. If |proxy| is not null, it should also create a
238 // RenderFrameProxy to replace the RenderFrame and set it to |is_loading| 238 // RenderFrameProxy to replace the RenderFrame and set it to |is_loading|
239 // state. The renderer should preserve the RenderFrameProxy object until it 239 // state. The renderer should preserve the RenderFrameProxy object until it
240 // exits, in case we come back. The renderer can exit if it has no other 240 // exits, in case we come back. The renderer can exit if it has no other
241 // active RenderFrames, but not until WasSwappedOut is called. 241 // active RenderFrames, but not until WasSwappedOut is called.
242 void SwapOut(RenderFrameProxyHost* proxy, bool is_loading); 242 void SwapOut(RenderFrameProxyHost* proxy, bool is_loading);
243 243
244 bool is_waiting_for_beforeunload_ack() const { 244 // Whether an ongoing navigation is waiting for a BeforeUnload ACK from the
245 return is_waiting_for_beforeunload_ack_; 245 // renderer. Currently this only happens in cross-site navigations.
nasko 2015/01/17 00:22:01 nit: s/renderer/RenderFrame/
clamy 2015/01/19 17:29:20 Done.
246 } 246 // PlzNavigate: this happens in every navigation that is not same-page.
247 bool IsWaitingForBeforeUnloadACK() const;
247 248
248 // Whether the RFH is waiting for an unload ACK from the renderer. 249 // Whether the RFH is waiting for an unload ACK from the renderer.
249 bool IsWaitingForUnloadACK() const; 250 bool IsWaitingForUnloadACK() const;
250 251
251 // Called when either the SwapOut request has been acknowledged or has timed 252 // Called when either the SwapOut request has been acknowledged or has timed
252 // out. 253 // out.
253 void OnSwappedOut(); 254 void OnSwappedOut();
254 255
255 // Whether this RenderFrameHost has been swapped out, such that the frame is 256 // Whether this RenderFrameHost has been swapped out, such that the frame is
256 // now rendered by a RenderFrameHost in a different process. 257 // now rendered by a RenderFrameHost in a different process.
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 618
618 // NOTE: This must be the last member. 619 // NOTE: This must be the last member.
619 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 620 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
620 621
621 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 622 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
622 }; 623 };
623 624
624 } // namespace content 625 } // namespace content
625 626
626 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 627 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698