Ensure that before creating proxy of site A, RVH of site A is initialized.

content/browser/frame_host/render_frame_host_manager_unittest.cc

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index 079c6c4a3e1ea1b9d31f970bc5f0c7aec142dcb6..1656b0b795c8bc28443e2504b546278dd4ecdaa6 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -1416,9 +1416,10 @@ TEST_F(RenderFrameHostManagerTest, CleanUpSwappedOutRVHOnProcessCrash) {
       Details<RenderProcessHost::RendererClosedDetails>(&details));
   rvh1->set_render_view_created(false);
 
-  // Ensure that the swapped out RenderViewHost has been deleted.
-  EXPECT_FALSE(opener1_manager->GetSwappedOutRenderViewHost(
-      rvh1->GetSiteInstance()));
+  // Ensure that the RenderFrameProxy is deleted.
+  EXPECT_FALSE(
+      opener1_manager->GetRenderFrameProxyHost(
+          rvh1->GetSiteInstance())->is_render_frame_proxy_live());

[nasko, 2015/02/03 21:29:36]

Let's split this into two checks: EXPECT_TRUE for RFH, so we don't just crash
and then the liveness check.

Also, we need to keep the previous check, but update it to reflect reality: the
RVH should exist, but we should also confirm it is *not* live. 

[lazyboy, 2015/02/03 23:15:14]

Done.
 
I've added the check for the existence of RVH, but cannot check the live-ness as
this is a TestRenderViewHost and the process crash is faked by sending a
notification. TestRenderViewHost manually manages IsRenderViewLive, the rvh
can be made not live by calling set_render_view_created(false). However, adding
that call and checking !IsRenderViewLive() seems pointless.
The |is_render_frame_proxy_live()| call above however, should cover the case.

[nasko, 2015/02/03 23:39:50]

I wonder if the test can be made more realistic by not faking the notification
and just doing the RenderProcessGone. Though this seems like a bigger change and
a bit more out of scope for this CL. Can you put a TODO(nasko) above the
simulation to investigate that and not faking the created boolean?

[lazyboy, 2015/02/03 23:55:41]

Done.

 
   // Reload the initial tab. This should recreate the opener's swapped out RVH
   // in the original SiteInstance.