Ensure that before creating proxy of site A, RVH of site A is initialized.

content/browser/frame_host/render_frame_host_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
@@ skipping 1398 matching lines @@
   // Fake a process crash.
   RenderProcessHost::RendererClosedDetails details(
       base::TERMINATION_STATUS_PROCESS_CRASHED,
       0);
   NotificationService::current()->Notify(
       NOTIFICATION_RENDERER_PROCESS_CLOSED,
       Source<RenderProcessHost>(rvh1->GetProcess()),
       Details<RenderProcessHost::RendererClosedDetails>(&details));
   rvh1->set_render_view_created(false);
 
-  // Ensure that the swapped out RenderViewHost has been deleted.
-  EXPECT_FALSE(opener1_manager->GetSwappedOutRenderViewHost(
-      rvh1->GetSiteInstance()));
+  // Ensure that the RenderFrameProxy is deleted.
+  EXPECT_FALSE(
+      opener1_manager->GetRenderFrameProxyHost(
+          rvh1->GetSiteInstance())->is_render_frame_proxy_live());

[nasko, 2015/02/03 21:29:36]

Let's split this into two checks: EXPECT_TRUE for RFH, so we don't just crash
and then the liveness check.

Also, we need to keep the previous check, but update it to reflect reality: the
RVH should exist, but we should also confirm it is *not* live. 

[lazyboy, 2015/02/03 23:15:14]

Done.
 
I've added the check for the existence of RVH, but cannot check the live-ness as
this is a TestRenderViewHost and the process crash is faked by sending a
notification. TestRenderViewHost manually manages IsRenderViewLive, the rvh
can be made not live by calling set_render_view_created(false). However, adding
that call and checking !IsRenderViewLive() seems pointless.
The |is_render_frame_proxy_live()| call above however, should cover the case.

[nasko, 2015/02/03 23:39:50]

I wonder if the test can be made more realistic by not faking the notification
and just doing the RenderProcessGone. Though this seems like a bigger change and
a bit more out of scope for this CL. Can you put a TODO(nasko) above the
simulation to investigate that and not faking the created boolean?

[lazyboy, 2015/02/03 23:55:41]

Done.

 
   // Reload the initial tab. This should recreate the opener's swapped out RVH
   // in the original SiteInstance.
   contents()->GetController().Reload(true);
   contents()->GetMainFrame()->PrepareForCommit(kUrl1);
   EXPECT_EQ(opener1_manager->GetSwappedOutRenderViewHost(
                 rvh1->GetSiteInstance())->GetRoutingID(),
             test_rvh()->opener_route_id());
 }
 
@@ skipping 449 matching lines @@
 #if 0
   // TODO(nick): Currently a proxy to the removed frame lingers in the parent.
   // Enable this assert below once the proxies to the subframe are correctly
   // cleaned up after detach. http://crbug.com/444955.
   ASSERT_TRUE(site_instance->HasOneRef())
       << "This SiteInstance should be destroyable now.";
 #endif
 }
 
 }  // namespace content