Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 774183004: Upstream historical tab logic (Closed)

Created:
6 years ago by gone
Modified:
6 years ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@upstreaming_2
Project:
chromium
Visibility:
Public.

Description

Upstream historical tab logic Moves code from ChromeTab to Tab and TabState. BUG=415747 Committed: https://crrev.com/7a7d0e676c4fea6eb183b12f3f2a324ced8f5628 Cr-Commit-Position: refs/heads/master@{#306861}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabState.java View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 2 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_state.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
gone
6 years ago (2014-12-04 00:30:15 UTC) #2
gone
6 years ago (2014-12-04 00:59:40 UTC) #4
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/774183004/diff/1/chrome/browser/android/tab_android.cc File chrome/browser/android/tab_android.cc (right): https://chromiumcodereview.appspot.com/774183004/diff/1/chrome/browser/android/tab_android.cc#newcode684 chrome/browser/android/tab_android.cc:684: void TabAndroid::CreateHistoricalTabFromContents(WebContents* web_contents) { Put "// static" above ...
6 years ago (2014-12-04 07:45:27 UTC) #5
gone
https://chromiumcodereview.appspot.com/774183004/diff/1/chrome/browser/android/tab_android.cc File chrome/browser/android/tab_android.cc (right): https://chromiumcodereview.appspot.com/774183004/diff/1/chrome/browser/android/tab_android.cc#newcode684 chrome/browser/android/tab_android.cc:684: void TabAndroid::CreateHistoricalTabFromContents(WebContents* web_contents) { On 2014/12/04 07:45:27, David Trainor ...
6 years ago (2014-12-04 18:19:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774183004/20001
6 years ago (2014-12-04 18:20:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-04 18:57:24 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-04 18:58:13 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7a7d0e676c4fea6eb183b12f3f2a324ced8f5628
Cr-Commit-Position: refs/heads/master@{#306861}

Powered by Google App Engine
This is Rietveld 408576698