Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 74063005: Switched remaining GPU test bots to be pure testers, triggered by builders. (Closed)

Created:
7 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org, ghost stip (do not use), agable, bajones, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Switched remaining GPU test bots to be pure testers, triggered by builders. Note that the try servers on the tryserver.chromium waterfall remain independent builder/testers. Tested locally with runbuild.py, masters_test.py, and masters_cfg_test.py. BUG=310926 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=235483

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed stip's review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -104 lines) Patch
M masters/master.chromium.gpu.fyi/master.cfg View 4 chunks +6 lines, -25 lines 0 comments Download
M masters/master.chromium.gpu.fyi/slaves.cfg View 4 chunks +8 lines, -4 lines 0 comments Download
M masters/master.chromium.gpu/master.cfg View 4 chunks +6 lines, -47 lines 0 comments Download
M masters/master.chromium.gpu/slaves.cfg View 1 13 chunks +26 lines, -13 lines 0 comments Download
M masters/master.chromium.webkit/master_gpu_latest_cfg.py View 1 5 chunks +61 lines, -15 lines 0 comments Download
A scripts/master/recipe_master_helper.py View 1 chunk +112 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ken Russell (switch to Gerrit)
Robbie: please review. Thanks. Mike, Aaron: FYI.
7 years, 1 month ago (2013-11-16 00:29:14 UTC) #1
Ken Russell (switch to Gerrit)
+bajones, zmo as FYI
7 years, 1 month ago (2013-11-16 00:39:52 UTC) #2
ghost stip (do not use)
some comments https://chromiumcodereview.appspot.com/74063005/diff/1/masters/master.chromium.gpu/slaves.cfg File masters/master.chromium.gpu/slaves.cfg (right): https://chromiumcodereview.appspot.com/74063005/diff/1/masters/master.chromium.gpu/slaves.cfg#newcode211 masters/master.chromium.gpu/slaves.cfg:211: 'version': 'precise', trailing space? https://chromiumcodereview.appspot.com/74063005/diff/1/masters/master.chromium.webkit/master_gpu_latest_cfg.py File masters/master.chromium.webkit/master_gpu_latest_cfg.py ...
7 years, 1 month ago (2013-11-16 01:15:28 UTC) #3
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/74063005/diff/1/masters/master.chromium.gpu/slaves.cfg File masters/master.chromium.gpu/slaves.cfg (right): https://codereview.chromium.org/74063005/diff/1/masters/master.chromium.gpu/slaves.cfg#newcode211 masters/master.chromium.gpu/slaves.cfg:211: 'version': 'precise', On 2013/11/16 01:15:28, stip wrote: > trailing ...
7 years, 1 month ago (2013-11-16 01:25:05 UTC) #4
ghost stip (do not use)
lgtm
7 years, 1 month ago (2013-11-16 01:27:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/74063005/80001
7 years, 1 month ago (2013-11-16 01:27:34 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-16 01:28:32 UTC) #7
Message was sent while issue was closed.
Change committed as 235483

Powered by Google App Engine
This is Rietveld 408576698