content/renderer/render_view_impl.cc - Issue 714003002: Allow changing top controls height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 714003002: Allow changing top controls height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added more invalidates when setting the height Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 7f38d6c98c43cf5910a9efe523420224fe8b32d7..2edec8e367bba9ca5eebe858da22030d765a155e 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3100,7 +3100,8 @@ void RenderViewImpl::OnDisableAutoResize(const gfx::Size& new_size) {

if (!new_size.IsEmpty()) {

Resize(new_size,

physical_backing_size_,

- top_controls_layout_height_,

+ top_controls_shrink_blink_size_,

+ top_controls_height_,

visible_viewport_size_,

resizer_rect_,

is_fullscreen_,

@@ -4157,7 +4158,8 @@ void RenderViewImpl::SetDeviceScaleFactorForTesting(float factor) {

params.visible_viewport_size = visible_viewport_size_;

params.physical_backing_size =

gfx::ToCeiledSize(gfx::ScaleSize(size(), factor));

- params.top_controls_layout_height = 0.f;

+ params.top_controls_shrink_blink_size = false;

+ params.top_controls_height = 0.f;

params.resizer_rect = WebRect();

params.is_fullscreen = is_fullscreen();

OnResize(params);