Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 714003002: Allow changing top controls height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more invalidates when setting the height Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc
index 29d3bcf05feed4d11a40f3a6c90dddc89dd72aff..53ade37e824a58ca8f29cbe545769e7bfe4c21fa 100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -239,22 +239,6 @@ scoped_ptr<RenderWidgetCompositor> RenderWidgetCompositor::Create(
settings.calculate_top_controls_position =
cmd->HasSwitch(cc::switches::kEnableTopControlsPositionCalculation);
- if (cmd->HasSwitch(cc::switches::kTopControlsHeight)) {
- std::string controls_height_str =
- cmd->GetSwitchValueASCII(cc::switches::kTopControlsHeight);
- double controls_height;
- if (base::StringToDouble(controls_height_str, &controls_height) &&
- controls_height > 0)
- settings.top_controls_height = controls_height;
- }
-
- if (settings.calculate_top_controls_position &&
- settings.top_controls_height <= 0) {
- DCHECK(false)
- << "Top controls repositioning enabled without valid height set.";
- settings.calculate_top_controls_position = false;
- }
-
if (cmd->HasSwitch(cc::switches::kTopControlsShowThreshold)) {
std::string top_threshold_str =
cmd->GetSwitchValueASCII(cc::switches::kTopControlsShowThreshold);
@@ -461,8 +445,12 @@ void RenderWidgetCompositor::UpdateTopControlsState(
animate);
}
-void RenderWidgetCompositor::SetTopControlsLayoutHeight(float height) {
- layer_tree_host_->SetTopControlsLayoutHeight(height);
+void RenderWidgetCompositor::SetTopControlsShrinkBlinkSize(bool shrink) {
+ layer_tree_host_->SetTopControlsShrinkBlinkSize(shrink);
+}
+
+void RenderWidgetCompositor::SetTopControlsHeight(float height) {
+ layer_tree_host_->SetTopControlsHeight(height);
}
void RenderWidgetCompositor::SetNeedsRedrawRect(gfx::Rect damage_rect) {

Powered by Google App Engine
This is Rietveld 408576698