Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 71013006: Make checking tokens default in lexer-shell. (Closed)

Created:
7 years, 1 month ago by ulan
Modified:
7 years, 1 month ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Make checking tokens default in lexer-shell. R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17681

Patch Set 1 #

Patch Set 2 : Adjust output for --benchmark flag. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M src/lexer/lexer-shell.cc View 1 7 chunks +23 lines, -13 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 1 month ago (2013-11-13 09:57:02 UTC) #1
marja
lgtm lgtm % https://chromiumcodereview.appspot.com/71013006/diff/40001/src/lexer/lexer-shell.cc File src/lexer/lexer-shell.cc (right): https://chromiumcodereview.appspot.com/71013006/diff/40001/src/lexer/lexer-shell.cc#newcode269 src/lexer/lexer-shell.cc:269: bool no_check = false; I tried ...
7 years, 1 month ago (2013-11-13 10:18:31 UTC) #2
ulan
7 years, 1 month ago (2013-11-13 10:23:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698