Merge browser/ui/password and browser/ui/passwords.

Merge browser/ui/password and browser/ui/passwords.

Merge browser/ui/password and browser/ui/passwords. Somehow they got
created by concurrent CLs. Also move PasswordManagerPresenter to
browser/ui/passwords.

BUG=248589
TBR=jhawkins

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235080

[shashi, 2013-11-13 01:03:04]

dubroy: review.
markusheintz: Owners approval.

[markusheintz_, 2013-11-13 01:17:53]

This CL will move the WebUI specific C++ files in a directory for with non WebUI
specific code.

Is this what we want? Or should we distinguish within the passwords dir which
code is webui or non webui related code by having a subdir ?

From the related issue it seems that the passwords code move by this CL is being
re factored to be used by android. If this is the case then all looks good to
me.

[markusheintz_, 2013-11-13 01:22:48]

cc: Naomi

[shashi, 2013-11-13 01:22:54]

Yes, I did not move them in the first place, since it would be difficult to
review the diff.

Android cannot depend on WebUI, so the initial CL was to make the logic part
agnostic of WebUI.

[markusheintz_, 2013-11-13 02:08:21]

OWNERS LGTM from my side from moving the code.

[Patrick Dubroy, 2013-11-13 11:38:07]

https://codereview.chromium.org/71003002/diff/200001/chrome/browser/ui/passwo...
File chrome/browser/ui/passwords/password_manager_presenter.h (right):

https://codereview.chromium.org/71003002/diff/200001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/password_manager_presenter.h:26: namespace
passwords_ui {
I don't think you need this namespace. I think the general consensus on Chrome
is slightly biased against namespaces (see
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OIkJO2KQKTQ/YQzUS...),
and in this case the class is already unambiguously named.

https://codereview.chromium.org/71003002/diff/200001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/password_manager_presenter.h:54: void
RemoveSavedPassword(size_t index);
+1 for renaming these :-)

https://codereview.chromium.org/71003002/diff/200001/chrome/browser/ui/passwo...
File chrome/browser/ui/passwords/password_manager_presenter_unittest.cc (right):

https://codereview.chromium.org/71003002/diff/200001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/password_manager_presenter_unittest.cc:44: namespace
passwords_ui {
I'd drop the namespace here as well.

[shashi, 2013-11-13 17:44:22]

PTAL

https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
File chrome/browser/ui/passwords/password_manager_presenter.h (right):

https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
chrome/browser/ui/passwords/password_manager_presenter.h:26: namespace
passwords_ui {
On 2013/11/13 11:38:07, Patrick Dubroy wrote:
> I don't think you need this namespace. I think the general consensus on Chrome
> is slightly biased against namespaces (see
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OIkJO2KQKTQ/YQzUS...),
> and in this case the class is already unambiguously named.

Done.

https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
File chrome/browser/ui/passwords/password_manager_presenter_unittest.cc (right):

https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
chrome/browser/ui/passwords/password_manager_presenter_unittest.cc:44: namespace
passwords_ui {
On 2013/11/13 11:38:07, Patrick Dubroy wrote:
> I'd drop the namespace here as well.

Done.

[Patrick Dubroy, 2013-11-13 18:18:56]

On 2013/11/13 17:44:22, shashi wrote:
> PTAL
> 
>
https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
> File chrome/browser/ui/passwords/password_manager_presenter.h (right):
> 
>
https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
> chrome/browser/ui/passwords/password_manager_presenter.h:26: namespace
> passwords_ui {
> On 2013/11/13 11:38:07, Patrick Dubroy wrote:
> > I don't think you need this namespace. I think the general consensus on
Chrome
> > is slightly biased against namespaces (see
> >
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OIkJO2KQKTQ/YQzUS...),
> > and in this case the class is already unambiguously named.
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
> File chrome/browser/ui/passwords/password_manager_presenter_unittest.cc
(right):
> 
>
https://chromiumcodereview.appspot.com/71003002/diff/200001/chrome/browser/ui...
> chrome/browser/ui/passwords/password_manager_presenter_unittest.cc:44:
namespace
> passwords_ui {
> On 2013/11/13 11:38:07, Patrick Dubroy wrote:
> > I'd drop the namespace here as well.
> 
> Done.

lgtm

[commit-bot: I haz the power, 2013-11-13 18:59:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/71003002/31...

[commit-bot: I haz the power, 2013-11-13 19:26:59]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-11-13 19:36:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/71003002/31...

[commit-bot: I haz the power, 2013-11-13 20:33:23]

Retried try job too often on win_x64_rel for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2013-11-13 20:39:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/71003002/31...

[commit-bot: I haz the power, 2013-11-13 21:21:25]

Retried try job too often on win_x64_rel for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2013-11-14 00:02:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/71003002/75...

[commit-bot: I haz the power, 2013-11-14 07:05:19]

Change committed as 235080