[ui/ios] Add helper methods for getting the bounding size of some text.

[ui/ios] Add helper methods for getting the bounding size of some text.

These helpers are meant to ease the transition from the deprecated
|sizeWithFont:constrainedToSize:| methods. They'll also help reduce
boilerplate compared to the iOS method
|boundingRectWithSize:options:attributes:context:|

BUG=364419
Committed: https://crrev.com/4981664e4c0407a7fb7443733f989991e3f883a6
Cr-Commit-Position: refs/heads/master@{#303237}

[lliabraa, 2014-11-06 16:10:20]

lliabraa@chromium.org changed reviewers:
+ lpromero@chromium.org

[lpromero, 2014-11-06 16:17:44]

lgtm

https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
File ui/ios/NSString+CrStringDrawing.h (right):

https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
ui/ios/NSString+CrStringDrawing.h:19: //  - attributes: a NSDictionary with the
provided |font|.
The period could go on the next line.

https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
ui/ios/NSString+CrStringDrawing.h:22: // Note that the rect returned may contain
fractional values.
What do you think of:

+// Use |ceil| to raise the size values to the nearest higher integer.

https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
ui/ios/NSString+CrStringDrawing.h:28: // Note that the size returned may contain
fractional values.
Idem?

[lpromero, 2014-11-06 16:17:55]

On 2014/11/06 16:17:44, lpromero wrote:
> lgtm
> 
>
https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
> File ui/ios/NSString+CrStringDrawing.h (right):
> 
>
https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
> ui/ios/NSString+CrStringDrawing.h:19: //  - attributes: a NSDictionary with
the
> provided |font|.
> The period could go on the next line.
> 
>
https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
> ui/ios/NSString+CrStringDrawing.h:22: // Note that the rect returned may
contain
> fractional values.
> What do you think of:
> 
> +// Use |ceil| to raise the size values to the nearest higher integer.
> 
>
https://codereview.chromium.org/704283002/diff/1/ui/ios/NSString+CrStringDraw...
> ui/ios/NSString+CrStringDrawing.h:28: // Note that the size returned may
contain
> fractional values.
> Idem?

Thanks for this CL!

[lliabraa, 2014-11-06 16:35:47]

thanks for the review.

https://chromiumcodereview.appspot.com/704283002/diff/1/ui/ios/NSString+CrStr...
File ui/ios/NSString+CrStringDrawing.h (right):

https://chromiumcodereview.appspot.com/704283002/diff/1/ui/ios/NSString+CrStr...
ui/ios/NSString+CrStringDrawing.h:19: //  - attributes: a NSDictionary with the
provided |font|.
On 2014/11/06 16:17:44, lpromero wrote:
> The period could go on the next line.

Done.

https://chromiumcodereview.appspot.com/704283002/diff/1/ui/ios/NSString+CrStr...
ui/ios/NSString+CrStringDrawing.h:22: // Note that the rect returned may contain
fractional values.
On 2014/11/06 16:17:43, lpromero wrote:
> What do you think of:
> 
> +// Use |ceil| to raise the size values to the nearest higher integer.

I've opted to return fractional values to keep the API closer to the behavior of
the corresponding iOS method. It also allows the unittest to compare results
between this and the deprecated method.

https://chromiumcodereview.appspot.com/704283002/diff/1/ui/ios/NSString+CrStr...
ui/ios/NSString+CrStringDrawing.h:28: // Note that the size returned may contain
fractional values.
On 2014/11/06 16:17:44, lpromero wrote:
> Idem?

Acknowledged.

[lliabraa, 2014-11-06 16:35:51]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-11-06 16:36:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/704283002/20001

[commit-bot: I haz the power, 2014-11-06 16:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-06 16:36:36]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[lliabraa, 2014-11-06 16:39:43]

lliabraa@chromium.org changed reviewers:
+ rohitrao@chromium.org

[lliabraa, 2014-11-06 16:39:43]

+rohitrao for full superstar committer review

[rohitrao (ping after 24h), 2014-11-07 14:21:26]

lgtm

https://codereview.chromium.org/704283002/diff/20001/ui/ios/NSString+CrString...
File ui/ios/NSString+CrStringDrawing.h (right):

https://codereview.chromium.org/704283002/diff/20001/ui/ios/NSString+CrString...
ui/ios/NSString+CrStringDrawing.h:29: -
(CGSize)cr_boundingSizeWithSize:(CGSize)size
Do we really need this as a convenience method?  Is it ugly for callers to just
call .size on the return value of the other method?

[lliabraa, 2014-11-07 14:34:40]

The CQ bit was checked by lliabraa@chromium.org

[lliabraa, 2014-11-07 14:34:51]

Thanks for the review

https://codereview.chromium.org/704283002/diff/20001/ui/ios/NSString+CrString...
File ui/ios/NSString+CrStringDrawing.h (right):

https://codereview.chromium.org/704283002/diff/20001/ui/ios/NSString+CrString...
ui/ios/NSString+CrStringDrawing.h:29: -
(CGSize)cr_boundingSizeWithSize:(CGSize)size
On 2014/11/07 14:21:26, rohitrao wrote:
> Do we really need this as a convenience method?  Is it ugly for callers to
just
> call .size on the return value of the other method?

We never access the origin part of the rect, so if we were to drop one of these
I'd vote for dropping the one that returns the rect.

[commit-bot: I haz the power, 2014-11-07 14:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/704283002/20001

[commit-bot: I haz the power, 2014-11-07 15:20:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-07 15:22:23]

Patchset 2 (id:??) landed as
https://crrev.com/4981664e4c0407a7fb7443733f989991e3f883a6
Cr-Commit-Position: refs/heads/master@{#303237}