dart2js: Use type-checks in later operations.

dart2js: Use type-checks in later operations.

We correctly GVNed type-checks (in checked mode), but we didn't always use the checks in later operations.

R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41605

[floitsch, 2014-11-07 12:42:17]

floitsch@google.com changed reviewers:
+ herhut@google.com

[herhut, 2014-11-07 13:36:58]

lgtm

However, I would prefer to build the graph like this directly in the builder
(because I would not expect type propagation to rewrite the graph to that
extent) but that would probably require a bigger refactoring. So just go ahead.

https://codereview.chromium.org/699593004/diff/1/tests/compiler/dart2js/use_c...
File tests/compiler/dart2js/use_checks_test.dart (right):

https://codereview.chromium.org/699593004/diff/1/tests/compiler/dart2js/use_c...
tests/compiler/dart2js/use_checks_test.dart:7: import 'memory_compiler.dart';
Nit: Do you need the memory compiler here or would the mock do? See
for_in_test.dart for an example with less boiler plate code.

[floitsch, 2014-11-07 13:58:16]

https://chromiumcodereview.appspot.com/699593004/diff/1/tests/compiler/dart2j...
File tests/compiler/dart2js/use_checks_test.dart (right):

https://chromiumcodereview.appspot.com/699593004/diff/1/tests/compiler/dart2j...
tests/compiler/dart2js/use_checks_test.dart:7: import 'memory_compiler.dart';
On 2014/11/07 13:36:58, herhut wrote:
> Nit: Do you need the memory compiler here or would the mock do? See
> for_in_test.dart for an example with less boiler plate code.

Unfortunately the mock compiler doesn't work.

[floitsch, 2014-11-07 13:58:30]

Committed patchset #1 (id:1) manually as 41605 (presubmit successful).