Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3561)

Unified Diff: chrome/browser/chromeos/login/user_manager_impl.cc

Issue 69863006: Address races in UserImageManagerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix WallpaperManager browser tests now that UserImageLoader contains a DCHECK(success). Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/user_manager_impl.cc b/chrome/browser/chromeos/login/user_manager_impl.cc
index e8291a6f04c2c6f257649d4068cac95bc7aad18e..8978a8124383010d94a6d8aa2fdde3bca1d911c1 100644
--- a/chrome/browser/chromeos/login/user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/user_manager_impl.cc
@@ -545,6 +545,13 @@ const User* UserManagerImpl::FindUser(const std::string& user_id) const {
return FindUserInList(user_id);
}
+User* UserManagerImpl::FindUserAndModify(const std::string& user_id) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ if (active_user_ && active_user_->email() == user_id)
+ return active_user_;
+ return FindUserInListAndModify(user_id);
+}
+
const User* UserManagerImpl::GetLoggedInUser() const {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
return active_user_;
@@ -1168,13 +1175,6 @@ UserList& UserManagerImpl::GetUsersAndModify() {
return users_;
}
-User* UserManagerImpl::FindUserAndModify(const std::string& user_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- if (active_user_ && active_user_->email() == user_id)
- return active_user_;
- return FindUserInListAndModify(user_id);
-}
-
const User* UserManagerImpl::FindUserInList(const std::string& user_id) const {
const UserList& users = GetUsers();
for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) {
« no previous file with comments | « chrome/browser/chromeos/login/user_manager_impl.h ('k') | chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698