Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: chrome/browser/chromeos/login/user_manager_impl.h

Issue 69863006: Address races in UserImageManagerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix WallpaperManager browser tests now that UserImageLoader contains a DCHECK(success). Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/user_manager.h ('k') | chrome/browser/chromeos/login/user_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/user_manager_impl.h
diff --git a/chrome/browser/chromeos/login/user_manager_impl.h b/chrome/browser/chromeos/login/user_manager_impl.h
index 173eab4b5fde41e90aa2093add11d7d85ddd1a3c..f645e983b88d156953bb141acea2884cdb6554d6 100644
--- a/chrome/browser/chromeos/login/user_manager_impl.h
+++ b/chrome/browser/chromeos/login/user_manager_impl.h
@@ -75,6 +75,7 @@ class UserManagerImpl
virtual void RemoveUserFromList(const std::string& user_id) OVERRIDE;
virtual bool IsKnownUser(const std::string& user_id) const OVERRIDE;
virtual const User* FindUser(const std::string& user_id) const OVERRIDE;
+ virtual User* FindUserAndModify(const std::string& user_id) OVERRIDE;
virtual const User* GetLoggedInUser() const OVERRIDE;
virtual User* GetLoggedInUser() OVERRIDE;
virtual const User* GetActiveUser() const OVERRIDE;
@@ -179,11 +180,6 @@ class UserManagerImpl
UserList& GetUsersAndModify();
// Returns the user with the given email address if found in the persistent
- // list or currently logged in as ephemeral. Returns |NULL| otherwise.
- // Same as FindUser but returns non-const pointer to User object.
- User* FindUserAndModify(const std::string& user_id);
-
- // Returns the user with the given email address if found in the persistent
// list. Returns |NULL| otherwise.
const User* FindUserInList(const std::string& user_id) const;
« no previous file with comments | « chrome/browser/chromeos/login/user_manager.h ('k') | chrome/browser/chromeos/login/user_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698