Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2677)

Unified Diff: chrome/common/extensions/docs/server2/app_yaml_helper.py

Issue 68873003: Docserver: Serve docs out of src/ not src/chrome/common/extensions. This allows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix samples Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/app_yaml_helper.py
diff --git a/chrome/common/extensions/docs/server2/app_yaml_helper.py b/chrome/common/extensions/docs/server2/app_yaml_helper.py
index afd03ba13c01220d417f9cde8eb47d38c4a589b7..d2bb706f97a7d133209336a17b48ef574b97f225 100644
--- a/chrome/common/extensions/docs/server2/app_yaml_helper.py
+++ b/chrome/common/extensions/docs/server2/app_yaml_helper.py
@@ -4,6 +4,9 @@
import logging
+from extensions_paths import APP_YAML
+
+
_APP_YAML_CONTAINER = '''
application: chrome-apps-doc
version: %s
@@ -12,15 +15,14 @@ api_version: 1
threadsafe: false
'''
+
class AppYamlHelper(object):
'''Parses the app.yaml file, and is able to step back in the host file
system's revision history to find when it changed to some given version.
'''
def __init__(self,
- app_yaml_path,
object_store_creator,
host_file_system_provider):
- self._app_yaml_path = app_yaml_path
self._store = object_store_creator.Create(
AppYamlHelper,
category=host_file_system_provider.GetTrunk().GetIdentity(),
@@ -72,8 +74,7 @@ class AppYamlHelper(object):
checked into the host file system.
'''
checked_in_app_version = AppYamlHelper.ExtractVersion(
- self._host_file_system_provider.GetTrunk().ReadSingle(
- self._app_yaml_path).Get())
+ self._host_file_system_provider.GetTrunk().ReadSingle(APP_YAML).Get())
if app_version == checked_in_app_version:
return True
if AppYamlHelper.IsGreater(app_version, checked_in_app_version):
@@ -100,11 +101,11 @@ class AppYamlHelper(object):
def _GetFirstRevisionGreaterThanImpl(self, app_version):
def get_app_yaml_revision(file_system):
- return int(file_system.Stat(self._app_yaml_path).version)
+ return int(file_system.Stat(APP_YAML).version)
def has_greater_app_version(file_system):
app_version_in_file_system = AppYamlHelper.ExtractVersion(
- file_system.ReadSingle(self._app_yaml_path).Get())
+ file_system.ReadSingle(APP_YAML).Get())
return AppYamlHelper.IsGreater(app_version_in_file_system, app_version)
found = None
« no previous file with comments | « chrome/common/extensions/docs/server2/app.yaml ('k') | chrome/common/extensions/docs/server2/app_yaml_helper_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698