Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 68873003: Docserver: Serve docs out of src/ not src/chrome/common/extensions. This allows (Closed)

Created:
7 years, 1 month ago by not at google - send to devlin
Modified:
7 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Serve docs out of src/ not src/chrome/common/extensions. This allows hosting non-extension content. BUG=293678 R=yoz@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235068

Patch Set 1 #

Patch Set 2 : make data source tests pass #

Patch Set 3 : Done #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : j -> join #

Patch Set 6 : fix samples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -421 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 11 chunks +11 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_data_source_test.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_list_data_source.py View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_list_data_source_test.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/api_models.py View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_models_test.py View 1 2 6 chunks +20 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/app_yaml_helper.py View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/app_yaml_helper_test.py View 1 2 6 chunks +26 lines, -27 lines 0 comments Download
M chrome/common/extensions/docs/server2/appengine_url_fetcher.py View 1 2 3 chunks +15 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/availability_finder.py View 1 2 4 chunks +12 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_providers.py View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_providers_test.py View 1 2 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron_servlet.py View 1 2 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron_servlet_test.py View 1 2 10 chunks +24 lines, -22 lines 0 comments Download
A chrome/common/extensions/docs/server2/extensions_paths.py View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/fake_fetchers.py View 1 2 3 3 chunks +52 lines, -81 lines 0 comments Download
M chrome/common/extensions/docs/server2/features_bundle.py View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/features_bundle_test.py View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/host_file_system_provider_test.py View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/integration_test.py View 1 2 3 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/intro_data_source.py View 3 chunks +10 lines, -13 lines 0 comments Download
M chrome/common/extensions/docs/server2/link_error_detector.py View 1 2 5 chunks +9 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/local_file_system.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/patch_servlet.py View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/path_canonicalizer.py View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/path_canonicalizer_test.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/permissions_data_source.py View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/permissions_data_source_test.py View 1 2 3 3 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet_test.py View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/rietveld_patcher.py View 6 chunks +15 lines, -33 lines 0 comments Download
M chrome/common/extensions/docs/server2/rietveld_patcher_test.py View 1 2 3 3 chunks +23 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_data_source.py View 1 2 3 4 5 9 chunks +13 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_data_source_test.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/server_instance.py View 5 chunks +2 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/sidenav_data_source.py View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/sidenav_data_source_test.py View 1 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/strings_data_source.py View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/subversion_file_system.py View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/subversion_file_system_test.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/server2/svn_constants.py View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source_test.py View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_data/canned_data.py View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_data/object_level_availability/tabs.py View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_file_system.py View 1 2 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_file_system_test.py View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_servlet.py View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_util.py View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/content_providers.json View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
Apologies for this patch. It took me ages to get right since there are so ...
7 years, 1 month ago (2013-11-13 00:12:42 UTC) #1
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/68873003/diff/50001/chrome/common/extensions/docs/server2/extensions_paths.py File chrome/common/extensions/docs/server2/extensions_paths.py (right): https://chromiumcodereview.appspot.com/68873003/diff/50001/chrome/common/extensions/docs/server2/extensions_paths.py#newcode5 chrome/common/extensions/docs/server2/extensions_paths.py:5: from posixpath import join as j "j" - ...
7 years, 1 month ago (2013-11-13 22:01:59 UTC) #2
not at google - send to devlin
https://chromiumcodereview.appspot.com/68873003/diff/50001/chrome/common/extensions/docs/server2/extensions_paths.py File chrome/common/extensions/docs/server2/extensions_paths.py (right): https://chromiumcodereview.appspot.com/68873003/diff/50001/chrome/common/extensions/docs/server2/extensions_paths.py#newcode5 chrome/common/extensions/docs/server2/extensions_paths.py:5: from posixpath import join as j On 2013/11/13 22:02:00, ...
7 years, 1 month ago (2013-11-13 22:05:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/68873003/120001
7 years, 1 month ago (2013-11-14 04:51:56 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 06:41:29 UTC) #5
Message was sent while issue was closed. 
Change committed as 235068

Powered by Google App Engine
This is Rietveld 408576698