history: more VoiceOver enhancements.

history: more VoiceOver enhancements.

- make each device contents an ordered list so we get "list 5 items" spoken.
- add a title to each ContextMenuButton so "Actions" is said instead of just "button".
- remove "required" from search input as it is spoken and unnecessary.
- create a useful summary aria-label for checkboxes so users can scroll quickly through entries

R=dmazzoni@chromium.org
BUG=385344
Committed: https://crrev.com/429c17d91afa37519b9c733a755d3887914a1d30
Cr-Commit-Position: refs/heads/master@{#300551}

[dmazzoni, 2014-10-21 05:11:33]

lgtm

https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
chrome/browser/resources/history/history.js:202:
checkbox.setAttribute('aria-label', summaryFields.join('\n'));
Maybe join with comma and space? This will get rendered in braille for some
users and a newline seems excessive.

[Dan Beam, 2014-10-21 05:14:03]

https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
chrome/browser/resources/history/history.js:202:
checkbox.setAttribute('aria-label', summaryFields.join('\n'));
On 2014/10/21 05:11:33, dmazzoni wrote:
> Maybe join with comma and space? This will get rendered in braille for some
> users and a newline seems excessive.

This was the only way that I thought would have a prayer of localizing well. I
don't know if comma+space works well in all languages.

[dmazzoni, 2014-10-21 05:17:30]

On 2014/10/21 05:14:03, Dan Beam wrote:
>
https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
> File chrome/browser/resources/history/history.js (right):
> 
>
https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
> chrome/browser/resources/history/history.js:202:
> checkbox.setAttribute('aria-label', summaryFields.join('\n'));
> On 2014/10/21 05:11:33, dmazzoni wrote:
> > Maybe join with comma and space? This will get rendered in braille for some
> > users and a newline seems excessive.
> 
> This was the only way that I thought would have a prayer of localizing well. I
> don't know if comma+space works well in all languages.

I think it's okay in this context. If we wanted to do it right, I wonder if we
could just have a set of generic i18n strings to use for joining things, like
"$1, $2", "$1, $2, $3", and so on?

[Dan Beam, 2014-10-21 18:57:48]

On 2014/10/21 05:17:30, dmazzoni wrote:
> On 2014/10/21 05:14:03, Dan Beam wrote:
> >
>
https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
> > File chrome/browser/resources/history/history.js (right):
> > 
> >
>
https://codereview.chromium.org/664863004/diff/60001/chrome/browser/resources...
> > chrome/browser/resources/history/history.js:202:
> > checkbox.setAttribute('aria-label', summaryFields.join('\n'));
> > On 2014/10/21 05:11:33, dmazzoni wrote:
> > > Maybe join with comma and space? This will get rendered in braille for
some
> > > users and a newline seems excessive.
> > 
> > This was the only way that I thought would have a prayer of localizing well.
I
> > don't know if comma+space works well in all languages.
> 
> I think it's okay in this context. If we wanted to do it right, I wonder if we
> could just have a set of generic i18n strings to use for joining things, like
> "$1, $2", "$1, $2, $3", and so on?

I don't know that generic would be good as I imagine this is highly contextual,
but I've added a history-specific string.  ptal.

[Dan Beam, 2014-10-21 19:23:11]

and now the summary includes whether a field is bookmarked

[dmazzoni, 2014-10-21 19:25:21]

lgtm

[Dan Beam, 2014-10-21 19:28:40]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-21 19:29:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664863004/100001

[commit-bot: I haz the power, 2014-10-21 20:43:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-21 20:43:57]

Patchset 6 (id:??) landed as
https://crrev.com/429c17d91afa37519b9c733a755d3887914a1d30
Cr-Commit-Position: refs/heads/master@{#300551}