Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 650693003: Enable OperatorWrap check as a warning for Java presubmit. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable OperatorWrap check as a warning for Java presubmit. There are currently 1072 violations of this check in chromium codebase. BUG=318404 Committed: https://crrev.com/663921b8a319557a315ffa31a568f60b22bafbab Cr-Commit-Position: refs/heads/master@{#300563}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added equals at the end of line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/android/checkstyle/chromium-style-5.0.xml View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aurimas (slooooooooow)
newt: PTAL
6 years, 2 months ago (2014-10-21 01:27:31 UTC) #2
newt (away)
question, then lgtm https://chromiumcodereview.appspot.com/650693003/diff/1/tools/android/checkstyle/chromium-style-5.0.xml File tools/android/checkstyle/chromium-style-5.0.xml (right): https://chromiumcodereview.appspot.com/650693003/diff/1/tools/android/checkstyle/chromium-style-5.0.xml#newcode168 tools/android/checkstyle/chromium-style-5.0.xml:168: <module name="OperatorWrap"> Do we also want ...
6 years, 2 months ago (2014-10-21 03:35:17 UTC) #3
aurimas (slooooooooow)
Added the extra check.
6 years, 2 months ago (2014-10-21 20:52:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650693003/20001
6 years, 2 months ago (2014-10-21 21:03:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 22:46:28 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 22:47:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/663921b8a319557a315ffa31a568f60b22bafbab
Cr-Commit-Position: refs/heads/master@{#300563}

Powered by Google App Engine
This is Rietveld 408576698