Chromium Code Reviews Chromium Code Reviews
Issue 650693003:
Enable OperatorWrap check as a warning for Java presubmit. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="UTF-8"?> | 1 <?xml version="1.0" encoding="UTF-8"?> |
| 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> | 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> |
| 3 | 3 |
| 4 <!-- | 4 <!-- |
| 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle | 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle |
| 6 --> | 6 --> |
| 7 <module name="Checker"> | 7 <module name="Checker"> |
| 8 <property name="severity" value="warning"/> | 8 <property name="severity" value="warning"/> |
| 9 <property name="charset" value="UTF-8"/> | 9 <property name="charset" value="UTF-8"/> |
| 10 <module name="TreeWalker"> | 10 <module name="TreeWalker"> |
| (...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 157 <property name="ordered" value="true"/> | 157 <property name="ordered" value="true"/> |
| 158 <property name="option" value="top"/> | 158 <property name="option" value="top"/> |
| 159 <property name="separated" value="true"/> | 159 <property name="separated" value="true"/> |
| 160 </module> | 160 </module> |
| 161 <module name="Indentation"> | 161 <module name="Indentation"> |
| 162 <property name="severity" value="error"/> | 162 <property name="severity" value="error"/> |
| 163 <property name="basicOffset" value="4"/> | 163 <property name="basicOffset" value="4"/> |
| 164 <property name="throwsIndent" value="8"/> | 164 <property name="throwsIndent" value="8"/> |
| 165 <property name="lineWrappingIndentation" value="8"/> | 165 <property name="lineWrappingIndentation" value="8"/> |
| 166 </module> | 166 </module> |
| 167 <!-- TODO(aurimas): make OperatorWrap into an error once all the warnings ar e fixed. --> | |
| 168 <module name="OperatorWrap"> | |
|
newt (away)
2014/10/21 03:35:16
Do we also want to check that "=" comes at the end
| |
| 169 <property name="severity" value="warning"/> | |
| 170 <property name="option" value="NL" /> | |
| 171 <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, L AND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR " /> | |
| 172 </module> | |
| 167 </module> | 173 </module> |
| 168 <module name="FileTabCharacter"> | 174 <module name="FileTabCharacter"> |
| 169 <property name="severity" value="error"/> | 175 <property name="severity" value="error"/> |
| 170 </module> | 176 </module> |
| 171 <module name="RegexpSingleline"> | 177 <module name="RegexpSingleline"> |
| 172 <property name="severity" value="error"/> | 178 <property name="severity" value="error"/> |
| 173 <property name="format" value="[ \t]+$"/> | 179 <property name="format" value="[ \t]+$"/> |
| 174 <property name="message" value="Trailing whitespace"/> | 180 <property name="message" value="Trailing whitespace"/> |
| 175 </module> | 181 </module> |
| 176 <module name="RegexpHeader"> | 182 <module name="RegexpHeader"> |
| 177 <property name="severity" value="error"/> | 183 <property name="severity" value="error"/> |
| 178 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> | 184 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> |
| 179 </module> | 185 </module> |
| 180 </module> | 186 </module> |
| OLD | NEW |
