content/browser/web_contents/web_contents_view.h - Issue 647613002: Fix RenderWidgetHostViewGuest leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view.h

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bring back mac delegate() Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view.h

diff --git a/content/browser/web_contents/web_contents_view.h b/content/browser/web_contents/web_contents_view.h

index 700194b5f1990e6ac00d2b39a10f074066eec8fa..47daee9bac8bd5df3199764b1f54b07fb8a09c95 100644

--- a/content/browser/web_contents/web_contents_view.h

+++ b/content/browser/web_contents/web_contents_view.h

@@ -79,8 +79,13 @@ class WebContentsView {

// Sets up the View that holds the rendered web page, receives messages for

// it and contains page plugins. The host view should be sized to the current

// size of the WebContents.

+ //

+ // |is_guest_view_hack| is temporary hack and will be removed once

+ // RenderWidgetHostViewGuest is not dependent on platform view.

+ // TODO(lazyboy): Remove |is_guest_view_hack| once http://crbug.com/330264 is

+ // fixed.

virtual RenderWidgetHostViewBase* CreateViewForWidget(

- RenderWidgetHost* render_widget_host) = 0;

+ RenderWidgetHost* render_widget_host, bool is_guest_view_hack) = 0;

// Creates a new View that holds a popup and receives messages for it.

virtual RenderWidgetHostViewBase* CreateViewForPopupWidget(