Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: content/browser/web_contents/web_contents_view.h

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bring back mac delegate() Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 // Get the bounds of the View, relative to the parent. 73 // Get the bounds of the View, relative to the parent.
74 virtual gfx::Rect GetViewBounds() const = 0; 74 virtual gfx::Rect GetViewBounds() const = 0;
75 75
76 virtual void CreateView( 76 virtual void CreateView(
77 const gfx::Size& initial_size, gfx::NativeView context) = 0; 77 const gfx::Size& initial_size, gfx::NativeView context) = 0;
78 78
79 // Sets up the View that holds the rendered web page, receives messages for 79 // Sets up the View that holds the rendered web page, receives messages for
80 // it and contains page plugins. The host view should be sized to the current 80 // it and contains page plugins. The host view should be sized to the current
81 // size of the WebContents. 81 // size of the WebContents.
82 //
83 // |is_guest_view_hack| is temporary hack and will be removed once
84 // RenderWidgetHostViewGuest is not dependent on platform view.
85 // TODO(lazyboy): Remove |is_guest_view_hack| once http://crbug.com/330264 is
86 // fixed.
82 virtual RenderWidgetHostViewBase* CreateViewForWidget( 87 virtual RenderWidgetHostViewBase* CreateViewForWidget(
83 RenderWidgetHost* render_widget_host) = 0; 88 RenderWidgetHost* render_widget_host, bool is_guest_view_hack) = 0;
84 89
85 // Creates a new View that holds a popup and receives messages for it. 90 // Creates a new View that holds a popup and receives messages for it.
86 virtual RenderWidgetHostViewBase* CreateViewForPopupWidget( 91 virtual RenderWidgetHostViewBase* CreateViewForPopupWidget(
87 RenderWidgetHost* render_widget_host) = 0; 92 RenderWidgetHost* render_widget_host) = 0;
88 93
89 // Sets the page title for the native widgets corresponding to the view. This 94 // Sets the page title for the native widgets corresponding to the view. This
90 // is not strictly necessary and isn't expected to be displayed anywhere, but 95 // is not strictly necessary and isn't expected to be displayed anywhere, but
91 // can aid certain debugging tools such as Spy++ on Windows where you are 96 // can aid certain debugging tools such as Spy++ on Windows where you are
92 // trying to find a specific window. 97 // trying to find a specific window.
93 virtual void SetPageTitle(const base::string16& title) = 0; 98 virtual void SetPageTitle(const base::string16& title) = 0;
(...skipping 23 matching lines...) Expand all
117 // true CloseTabAfterEventTracking() is called and the close is not 122 // true CloseTabAfterEventTracking() is called and the close is not
118 // completed. 123 // completed.
119 virtual bool IsEventTracking() const = 0; 124 virtual bool IsEventTracking() const = 0;
120 virtual void CloseTabAfterEventTracking() = 0; 125 virtual void CloseTabAfterEventTracking() = 0;
121 #endif 126 #endif
122 }; 127 };
123 128
124 } // namespace content 129 } // namespace content
125 130
126 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_H_ 131 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_VIEW_H_
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/browser/web_contents/web_contents_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698