Fix RenderWidgetHostViewGuest leak.

content/browser/web_contents/web_contents_view_mac.mm

Index: content/browser/web_contents/web_contents_view_mac.mm
diff --git a/content/browser/web_contents/web_contents_view_mac.mm b/content/browser/web_contents/web_contents_view_mac.mm
index c27c9927397f02c273ef4721495a1a56ad8db365..5fd3fb9ea7da2ae808acb784b236fb3ecc5d9a55 100644
--- a/content/browser/web_contents/web_contents_view_mac.mm
+++ b/content/browser/web_contents/web_contents_view_mac.mm
@@ -284,7 +284,7 @@ void WebContentsViewMac::CreateView(
 }
 
 RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForWidget(
-    RenderWidgetHost* render_widget_host) {
+    RenderWidgetHost* render_widget_host, bool is_guest_view_hack) {
   if (render_widget_host->GetView()) {
     // During testing, the view will already be set up in most cases to the
     // test view, so we don't want to clobber it with a real one. To verify that
@@ -297,8 +297,8 @@ RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForWidget(
   }
 
   RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(
-      render_widget_host);
-  if (delegate()) {
+      render_widget_host, is_guest_view_hack);
+  if (!is_guest_view_hack && delegate()) {

[lazyboy, 2014/10/16 06:14:24]

I needed to add this check here to fix mac crash.
Otherwise CreateRenderWidgetHostViewDelegate call below calls
initWithRenderWidgetHost, which in turn calls rwh->GetView()->GetNativeView()
and crashes.
PTAL.

[piman, 2014/10/16 20:47:47]

I'm no mac expert, not fully sure about everything the delegate is used for.
Looking at the code, it seems to do swipe history navigation (irrelevant for
guest), but spelling too, which seems like it would be important with the
current hookup.

Would it make more sense to fix initWithRenderWidgetHost? I'm not sure setting
VIEW_ID_TAB_CONTAINER as the view ID is right, it's not a tab container in the
case of a guest (i.e. if renderWidgetHost_->GetView() is NULL).
Another way is to pass the NSView explicitly.
A third way is to call this on the RWHVGuest after it has been created - but I
think it'd do the wrong thing (hooking up to the embedder's NSView).

[lazyboy, 2014/10/17 00:46:00]

I've done #2, check for GetView() before using it.

re: spellchecking, I was checking type and highlight spell mistakes in inputbox,
which seemed to work fine w/o this delegate(), but it seems this spellchecking
is a different mac specific one.
However, I'm getting blink assertion failures with or without this CL when I use
this spellchecking from guests, need to fix that separately.

     base::scoped_nsobject<NSObject<RenderWidgetHostViewMacDelegate> >
         rw_delegate(
             delegate()->CreateRenderWidgetHostViewDelegate(render_widget_host));
@@ -331,7 +331,7 @@ RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForWidget(
 
 RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForPopupWidget(
     RenderWidgetHost* render_widget_host) {
-  return new RenderWidgetHostViewMac(render_widget_host);
+  return new RenderWidgetHostViewMac(render_widget_host, false);
 }
 
 void WebContentsViewMac::SetPageTitle(const base::string16& title) {