Fix RenderWidgetHostViewGuest leak.

content/browser/web_contents/web_contents_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Carbon/Carbon.h>
 
 #import "content/browser/web_contents/web_contents_view_mac.h"
 
 #include <string>
 
@@ skipping 266 matching lines @@
 }
 
 void WebContentsViewMac::CreateView(
     const gfx::Size& initial_size, gfx::NativeView context) {
   WebContentsViewCocoa* view =
       [[WebContentsViewCocoa alloc] initWithWebContentsViewMac:this];
   cocoa_view_.reset(view);
 }
 
 RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForWidget(
-    RenderWidgetHost* render_widget_host) {
+    RenderWidgetHost* render_widget_host, bool is_guest_view_hack) {
   if (render_widget_host->GetView()) {
     // During testing, the view will already be set up in most cases to the
     // test view, so we don't want to clobber it with a real one. To verify that
     // this actually is happening (and somebody isn't accidentally creating the
     // view twice), we check for the RVH Factory, which will be set when we're
     // making special ones (which go along with the special views).
     DCHECK(RenderViewHostFactory::has_factory());
     return static_cast<RenderWidgetHostViewBase*>(
         render_widget_host->GetView());
   }
 
   RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(
-      render_widget_host);
-  if (delegate()) {
+      render_widget_host, is_guest_view_hack);
+  if (!is_guest_view_hack && delegate()) {

[lazyboy, 2014/10/16 06:14:24]

I needed to add this check here to fix mac crash.
Otherwise CreateRenderWidgetHostViewDelegate call below calls
initWithRenderWidgetHost, which in turn calls rwh->GetView()->GetNativeView()
and crashes.
PTAL.

[piman, 2014/10/16 20:47:47]

I'm no mac expert, not fully sure about everything the delegate is used for.
Looking at the code, it seems to do swipe history navigation (irrelevant for
guest), but spelling too, which seems like it would be important with the
current hookup.

Would it make more sense to fix initWithRenderWidgetHost? I'm not sure setting
VIEW_ID_TAB_CONTAINER as the view ID is right, it's not a tab container in the
case of a guest (i.e. if renderWidgetHost_->GetView() is NULL).
Another way is to pass the NSView explicitly.
A third way is to call this on the RWHVGuest after it has been created - but I
think it'd do the wrong thing (hooking up to the embedder's NSView).

[lazyboy, 2014/10/17 00:46:00]

I've done #2, check for GetView() before using it.

re: spellchecking, I was checking type and highlight spell mistakes in inputbox,
which seemed to work fine w/o this delegate(), but it seems this spellchecking
is a different mac specific one.
However, I'm getting blink assertion failures with or without this CL when I use
this spellchecking from guests, need to fix that separately.

     base::scoped_nsobject<NSObject<RenderWidgetHostViewMacDelegate> >
         rw_delegate(
             delegate()->CreateRenderWidgetHostViewDelegate(render_widget_host));
 
     view->SetDelegate(rw_delegate.get());
   }
   view->SetAllowPauseForResizeOrRepaint(!allow_other_views_);
 
   // Fancy layout comes later; for now just make it our size and resize it
   // with us. In case there are other siblings of the content area, we want
@@ skipping 12 matching lines @@
   // added. On 10.6 things magically work fine; on 10.5 they fail
   // <http://crbug.com/61493>. Digging into Cocoa key view loop code yielded
   // madness; TODO(avi,rohit): look at this again and figure out what's really
   // going on.
   [cocoa_view_.get() setNextKeyView:view_view];
   return view;
 }
 
 RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForPopupWidget(
     RenderWidgetHost* render_widget_host) {
-  return new RenderWidgetHostViewMac(render_widget_host);
+  return new RenderWidgetHostViewMac(render_widget_host, false);
 }
 
 void WebContentsViewMac::SetPageTitle(const base::string16& title) {
   // Meaningless on the Mac; widgets don't have a "title" attribute
 }
 
 
 void WebContentsViewMac::RenderViewCreated(RenderViewHost* host) {
   // We want updates whenever the intrinsic width of the webpage changes.
   // Put the RenderView into that mode. The preferred width is used for example
@@ skipping 232 matching lines @@
 // When the subviews require a layout, their size should be reset to the size
 // of this view. (It is possible for the size to get out of sync as an
 // optimization in preparation for an upcoming WebContentsView resize.
 // http://crbug.com/264207)
 - (void)resizeSubviewsWithOldSize:(NSSize)oldBoundsSize {
   for (NSView* subview in self.subviews)
     [subview setFrame:self.bounds];
 }
 
 @end