content/browser/web_contents/web_contents_view_android.h - Issue 647613002: Fix RenderWidgetHostViewGuest leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_android.h

Issue 647613002: Fix RenderWidgetHostViewGuest leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add is_guest_view_hack_ check in rwhvmac-delegate call (needs review) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_android.h

diff --git a/content/browser/web_contents/web_contents_view_android.h b/content/browser/web_contents/web_contents_view_android.h

index e4c9e60672c9e46b29f9e4370ede4007c3e6e2c9..c480c0e9bd96da5b892db41859ef7a866c729cf9 100644

--- a/content/browser/web_contents/web_contents_view_android.h

+++ b/content/browser/web_contents/web_contents_view_android.h

@@ -44,7 +44,7 @@ class WebContentsViewAndroid : public WebContentsView,

virtual void CreateView(

const gfx::Size& initial_size, gfx::NativeView context) override;

virtual RenderWidgetHostViewBase* CreateViewForWidget(

- RenderWidgetHost* render_widget_host) override;

+ RenderWidgetHost* render_widget_host, bool is_guest_view_hack) override;

virtual RenderWidgetHostViewBase* CreateViewForPopupWidget(

RenderWidgetHost* render_widget_host) override;

virtual void SetPageTitle(const base::string16& title) override;